Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation - Open Issue #272

Merged
merged 3 commits into from
Aug 16, 2024
Merged

Conversation

swetak20
Copy link
Contributor

Updated Documentation as per Issue #36

Copy link
Member

@forgedhallpass forgedhallpass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @swetak20,

Thank you for taking the time to contribute to the project, but unfortunately changing the URL is not enough. Please read the ticket. All the content from https://wiki.owasp.org/index.php/CSRFGuard_3_Token_Injection should be moved to this GitHub repository (correctly formatted), so it would show on the https://owasp.org/www-project-csrfguard/ page.

@swetak20
Copy link
Contributor Author

swetak20 commented May 28, 2024

I was working on migrating the contents to https://owasp.org/www-project-csrfguard/ and I believe it is currently generated from index.md. Could you confirm if this is correct?

@swetak20
Copy link
Contributor Author

I was checking the link in https://wiki.owasp.org/index.php/CSRFGuard_3_Token_Injection before migrating them, and they redirect to a 404.
Example - Owasp.CsrfGuard.Test

Could you suggest what should we cite the sources as in the updated documentation?

@forgedhallpass
Copy link
Member

I was working on migrating the contents to https://owasp.org/www-project-csrfguard/ and I believe it is currently generated from index.md. Could you confirm if this is correct?

Yes, the documentation is generated from the markdown files.

@forgedhallpass
Copy link
Member

I was checking the link in https://wiki.owasp.org/index.php/CSRFGuard_3_Token_Injection before migrating them, and they redirect to a 404. Example - Owasp.CsrfGuard.Test

Could you suggest what should we cite the sources as in the updated documentation?

The test properties files can be found in the following folder in the repository: https://github.com/OWASP/www-project-csrfguard/tree/master/csrfguard-test/csrfguard-test-jsp/src/main/webapp/WEB-INF/classes
The properties file also contains a lot of documentation in-line.

@swetak20
Copy link
Contributor Author

swetak20 commented Jun 1, 2024

@forgedhallpass I've made the requested changes. Please review the updates and let me know if there are any further adjustments needed.

@forgedhallpass forgedhallpass merged commit 7e9e4f6 into OWASP:master Aug 16, 2024
1 check passed
@forgedhallpass forgedhallpass linked an issue Aug 16, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate and update documentation
2 participants