Skip to content

Commit

Permalink
PAYPAL-735 remove sofort and mybank
Browse files Browse the repository at this point in the history
  • Loading branch information
@dmitriivolkhinoxid
dmitriivolkhinoxid committed Feb 1, 2024
1 parent 947602c commit 32aaa8a
Show file tree
Hide file tree
Showing 6 changed files with 24 additions and 94 deletions.
68 changes: 0 additions & 68 deletions src/Core/PayPalDefinitions.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ final class PayPalDefinitions
const PUI_PAYPAL_PAYMENT_ID = 'oscpaypal_pui';
const PUI_REQUEST_PAYMENT_SOURCE_NAME = 'pay_upon_invoice';
const GIROPAY_PAYPAL_PAYMENT_ID = 'oscpaypal_giropay';
const SOFORT_PAYPAL_PAYMENT_ID = 'oscpaypal_sofort';
const SEPA_PAYPAL_PAYMENT_ID = 'oscpaypal_sepa';
const CCALTERNATIVE_PAYPAL_PAYMENT_ID = 'oscpaypal_cc_alternative';

Expand Down Expand Up @@ -360,38 +359,6 @@ final class PayPalDefinitions
'buttonpayment' => false,
'defaulton' => true
],
// uAPM MyBank
'oscpaypal_mybank' => [
'descriptions' => [
'de' => [
'desc' => 'MyBank',
'longdesc' => '',
'longdesc_beta' => '<img src="https://www.paypalobjects.com/images/checkout/alternative_payments/paypal_mybank_color.svg" title="MyBank" style="float: left;margin-right: 10px;" />
MyBank bietet sichere und geschützte Banküberweisungen in Echtzeit zwischen Kunden
und Kaufleute. MyBank ist auf einer Vielzahl von Websites für den Kauf von Produkten verfügbar,
Dienstleistungen und für Zahlungen an Einrichtungen der öffentlichen Verwaltung. MyBank
ist eine flexibele Lösung für B2B- und B2C-Unternehmen: 40 Millionen aktivierte Kunden und über
210 Banken und PSPs haben sich dem MyBank-Netzwerk in ganz Europa angeschlossen.'
],
'en' => [
'desc' => 'MyBank',
'longdesc' => '',
'longdesc_beta' => '<img src="https://www.paypalobjects.com/images/checkout/alternative_payments/paypal_mybank_color.svg" title="MyBank" style="float: left;margin-right: 10px;" />
MyBank offers safe and protected real-time bank transfers between customers
and merchants. MyBank is available on a wide range of sites for the purchase of products,
services and for payments towards public administration entities. MyBank is a flexible
solution for both B2B and B2C businesses: 40 million enabled customers and over 210 banks
and PSPs have joined the MyBank network throughout Europe.'
]
],
'countries' => ['IT'],
'currencies' => ['EUR'],
'uapmpaymentsource' => 'mybank',
'constraints' => self::PAYMENT_CONSTRAINTS_UAPM,
'onlybrutto' => false,
'buttonpayment' => false,
'defaulton' => true
],
// uAPM Przelewy24
'oscpaypal_przelewy24' => [
'descriptions' => [
Expand Down Expand Up @@ -420,41 +387,6 @@ final class PayPalDefinitions
'buttonpayment' => false,
'defaulton' => true
],
// uAPM Sofort
self::SOFORT_PAYPAL_PAYMENT_ID => [
'descriptions' => [
'de' => [
'desc' => 'Sofort',
'longdesc' => '',
'longdesc_beta' => '<img src="https://www.paypalobjects.com/images/checkout/alternative_payments/paypal_sofort_black.svg" title="Sofort" style="float: left;margin-right: 10px;" />
Sofort, auch bekannt als Jetzt bezahlen mit Klarna, ist eine beliebte Online-
Banking-Methode in Deutschland, Österreich, der Schweiz und Belgien, was es zu einem Muss für
jedes Unternehmen macht, das in diesem Bereich tätig sein will. Im Jahr 2014 wurde Sofort von
Klarna und der Klarna Group übernommen. Bei Sofort nutzen sicherheitsbewusste Verbraucher ihre
eigenen Online-Banking-Daten, über die sichere Zahlungsseite von Sofort eingegeben. Einmal
eingeloggt, wird ein einmaliger Bestätigungs-Code vom Verbraucher verwendet, um die Zahlung zu
autorisieren.'
],
'en' => [
'desc' => 'Sofort',
'longdesc' => '',
'longdesc_beta' => '<img src="https://www.paypalobjects.com/images/checkout/alternative_payments/paypal_sofort_black.svg" title="Sofort" style="float: left;margin-right: 10px;" />
Sofort, also known as Pay now with Klarna, is a popular online banking method
in Germany, Austria, Switzerland and Belgium, making it a must-have for any business wanting
to operate in this area. In 2014 Sofort was acquired by Klarna and the Klarna Group was
established. With Sofort, security-conscious consumers use their own online banking details,
entered through the secure payment page of Sofort. Once logged in, a one-time confirmation
code is used by the consumer to authorize payment.'
]
],
'countries' => ['DE', 'AT', 'BE', 'IT', 'NL', 'GB', 'ES'],
'currencies' => ['EUR', 'GBP'],
'uapmpaymentsource' => 'sofort',
'constraints' => self::PAYMENT_CONSTRAINTS_UAPM,
'onlybrutto' => false,
'buttonpayment' => false,
'defaulton' => true
],
];

const PAYPAL_STATIC_CONTENTS = [
Expand Down
2 changes: 1 addition & 1 deletion src/Core/ViewConfig.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ public function getPayPalJsSdkUrl(): string
$params['enable-funding'] = 'paylater';
}

$params['disable-funding'] = 'sepa,bancontact,blik,eps,giropay,ideal,mercadopago,mybank,p24,sofort,venmo';
$params['disable-funding'] = 'sepa,bancontact,blik,eps,giropay,ideal,mercadopago,p24,venmo';

if ($moduleSettings->isAcdcEligibility()) {
$params['disable-funding'] .= ',card';
Expand Down
1 change: 0 additions & 1 deletion tests/Codeception/Acceptance/BaseCest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,6 @@ protected function enablePayments(AcceptanceTester $I): void
{
//we did not end up on shop start page
$I->updateInDatabase('oxpayments', ['oxactive' => 1], ['oxid' => 'oscpaypal_pui']);
$I->updateInDatabase('oxpayments', ['oxactive' => 1], ['oxid' => 'oscpaypal_sofort']);
$I->updateInDatabase('oxpayments', ['oxactive' => 1], ['oxid' => 'oscpaypal_acdc']);
$I->updateInDatabase('oxpayments', ['oxactive' => 1], ['oxid' => 'oscpaypal']);
}
Expand Down
1 change: 0 additions & 1 deletion tests/Codeception/Acceptance/UapmCheckoutCest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ public function _after(AcceptanceTester $I): void
protected function providerPaymentMethods(): array
{
return [
# ['paymentId' => PayPalDefinitions::SOFORT_PAYPAL_PAYMENT_ID],
['paymentId' => PayPalDefinitions::GIROPAY_PAYPAL_PAYMENT_ID]
];
}
Expand Down
14 changes: 7 additions & 7 deletions tests/Integration/Service/PaymentTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ final class PaymentTest extends BaseTestCase
'lysts\PayPalApi\Model\Orders\ThreeDSecureAuthenticationResponse":2:{s:21:"authentication_status";s:1:"Y";' .
's:17:"enrollment_status";s:1:"Y";}}s:10:"attributes";N;}s:6:"paypal";N;s:6:"wallet";N;s:4:"bank";N;s:6:"alipa' .
'y";N;s:10:"bancontact";N;s:4:"blik";N;s:14:"boletobancario";N;s:3:"eps";N;s:7:"giropay";N;s:5:"ideal";N;s:10:"m' .
'ultibanco";N;s:6:"mybank";N;s:4:"oxxo";N;s:4:"payu";N;s:3:"p24";N;s:16:"pay_upon_invoice";N;s:9:"safetypay";N;' .
's:8:"satispay";N;s:6:"sofort";N;s:7:"trustly";N;s:12:"verkkopankki";N;s:9:"wechatpay";N;s:9:"apple_pay";N;}' .
'ultibanco";N;s:4:"oxxo";N;s:4:"payu";N;s:3:"p24";N;s:16:"pay_upon_invoice";N;s:9:"safetypay";N;' .
's:8:"satispay";N;s:7:"trustly";N;s:12:"verkkopankki";N;s:9:"wechatpay";N;s:9:"apple_pay";N;}' .
's:6:"intent";N;s:22:"processing_instruction";s:14:"NO_INSTRUCTION";s:5:"payer";N;s:15:"expiration_time";N;' .
's:14:"purchase_units";a:0:{}s:6:"status";N;s:5:"links";N;s:22:"credit_financing_offer";N;s:19:"application_cont' .
'ext";N;s:11:"create_time";N;s:11:"update_time";N;}';
Expand All @@ -64,9 +64,9 @@ final class PaymentTest extends BaseTestCase
'onResponse":2:{s:15:"liability_shift";s:2:"NO";s:14:"three_d_secure";O:79:"OxidSolutionCatalysts\PayPalApi\Mod' .
'el\Orders\ThreeDSecureAuthenticationResponse":2:{s:21:"authentication_status";s:1:"N";s:17:"enrollment_status";' .
's:1:"Y";}}s:10:"attributes";N;}s:6:"paypal";N;s:6:"wallet";N;s:4:"bank";N;s:6:"alipay";N;s:10:"bancontact";N;' .
's:4:"blik";N;s:14:"boletobancario";N;s:3:"eps";N;s:7:"giropay";N;s:5:"ideal";N;s:10:"multibanco";N;s:6:"mybank";' .
'N;s:4:"oxxo";N;s:4:"payu";N;s:3:"p24";N;s:16:"pay_upon_invoice";N;s:9:"safetypay";N;s:8:"satispay";N;s:6:"sofort' .
'";N;s:7:"trustly";N;s:12:"verkkopankki";N;s:9:"wechatpay";N;s:9:"apple_pay";N;}s:6:"intent";N;s:22:"processing_i' .
's:4:"blik";N;s:14:"boletobancario";N;s:3:"eps";N;s:7:"giropay";N;s:5:"ideal";N;s:10:"multibanco";' .
'N;s:4:"oxxo";N;s:4:"payu";N;s:3:"p24";N;s:16:"pay_upon_invoice";N;s:9:"safetypay";N;s:8:"satispay";N;' .
';s:7:"trustly";N;s:12:"verkkopankki";N;s:9:"wechatpay";N;s:9:"apple_pay";N;}s:6:"intent";N;s:22:"processing_i' .
'nstruction";s:14:"NO_INSTRUCTION";s:5:"payer";N;s:15:"expiration_time";N;s:14:"purchase_units";a:0:{}s:6:"status' .
'";N;s:5:"links";N;s:22:"credit_financing_offer";N;s:19:"application_context";N;s:11:"create_time";N;s:11:"upda' .
'te_time";N;}';
Expand All @@ -77,8 +77,8 @@ final class PaymentTest extends BaseTestCase
'ess";N;s:12:"last_n_chars";N;s:11:"last_digits";s:4:"9760";s:5:"brand";s:4:"VISA";s:4:"type";s:6:"CREDIT";s:6:"i' .
'ssuer";N;s:3:"bin";N;s:21:"authentication_result";N;s:10:"attributes";N;}s:6:"paypal";N;s:6:"wallet";N;s:4:"ban' .
'k";N;s:6:"alipay";N;s:10:"bancontact";N;s:4:"blik";N;s:14:"boletobancario";N;s:3:"eps";N;s:7:"giropay";N;s:5:"id' .
'eal";N;s:10:"multibanco";N;s:6:"mybank";N;s:4:"oxxo";N;s:4:"payu";N;s:3:"p24";N;s:16:"pay_upon_invoice";N;s:9:"s' .
'afetypay";N;s:8:"satispay";N;s:6:"sofort";N;s:7:"trustly";N;s:12:"verkkopankki";N;s:9:"wechatpay";N;s:9:"appl' .
'eal";N;s:10:"multibanco";N;s:4:"oxxo";N;s:4:"payu";N;s:3:"p24";N;s:16:"pay_upon_invoice";N;s:9:"s' .
'afetypay";N;s:8:"satispay";N;s:7:"trustly";N;s:12:"verkkopankki";N;s:9:"wechatpay";N;s:9:"appl' .
'e_pay";N;}s:6:"intent";N;s:22:"processing_instruction";s:14:"NO_INSTRUCTION";s:5:"payer";N;s:15:"expiration_ti' .
'me";N;s:14:"purchase_units";a:0:{}s:6:"status";N;s:5:"links";N;s:22:"credit_financing_offer";N;s:19:"applicat' .
'ion_context";N;s:11:"create_time";N;s:11:"update_time";N;}';
Expand Down
Loading

0 comments on commit 32aaa8a

Please sign in to comment.