Export cli server flags and etcd restoration functions (k3s-io#3527)

* Export cli server flags and etfd restoration functions Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com> * export S3 Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com> Signed-off-by: Chris Kim <oats87g@gmail.com>
Oats87 · Nov 12, 2021 · 78e7402 · 78e7402
1 parent c9d4543
commit 78e7402
Show file tree

Hide file tree

Showing 3 changed files with 57 additions and 47 deletions.
diff --git a/pkg/cli/cmds/server.go b/pkg/cli/cmds/server.go
@@ -83,7 +83,51 @@ type Server struct {
 	EtcdS3Insecure           bool
 }
 
-var ServerConfig Server
+var (
+	ServerConfig Server
+	ClusterCIDR  = cli.StringSliceFlag{
+		Name:  "cluster-cidr",
+		Usage: "(networking) IPv4/IPv6 network CIDRs to use for pod IPs (default: 10.42.0.0/16)",
+		Value: &ServerConfig.ClusterCIDR,
+	}
+	ServiceCIDR = cli.StringSliceFlag{
+		Name:  "service-cidr",
+		Usage: "(networking) IPv4/IPv6 network CIDRs to use for service IPs (default: 10.43.0.0/16)",
+		Value: &ServerConfig.ServiceCIDR,
+	}
+	ServiceNodePortRange = cli.StringFlag{
+		Name:        "service-node-port-range",
+		Usage:       "(networking) Port range to reserve for services with NodePort visibility",
+		Destination: &ServerConfig.ServiceNodePortRange,
+		Value:       "30000-32767",
+	}
+	ClusterDNS = cli.StringSliceFlag{
+		Name:  "cluster-dns",
+		Usage: "(networking) IPv4 Cluster IP for coredns service. Should be in your service-cidr range (default: 10.43.0.10)",
+		Value: &ServerConfig.ClusterDNS,
+	}
+	ClusterDomain = cli.StringFlag{
+		Name:        "cluster-domain",
+		Usage:       "(networking) Cluster Domain",
+		Destination: &ServerConfig.ClusterDomain,
+		Value:       "cluster.local",
+	}
+	ExtraAPIArgs = cli.StringSliceFlag{
+		Name:  "kube-apiserver-arg",
+		Usage: "(flags) Customized flag for kube-apiserver process",
+		Value: &ServerConfig.ExtraAPIArgs,
+	}
+	ExtraSchedulerArgs = cli.StringSliceFlag{
+		Name:  "kube-scheduler-arg",
+		Usage: "(flags) Customized flag for kube-scheduler process",
+		Value: &ServerConfig.ExtraSchedulerArgs,
+	}
+	ExtraControllerArgs = cli.StringSliceFlag{
+		Name:  "kube-controller-manager-arg",
+		Usage: "(flags) Customized flag for kube-controller-manager process",
+		Value: &ServerConfig.ExtraControllerArgs,
+	}
+)
 
 func NewServerCommand(action func(*cli.Context) error) cli.Command {
 	return cli.Command{
@@ -130,33 +174,11 @@ func NewServerCommand(action func(*cli.Context) error) cli.Command {
 				Usage:       "(data) Folder to hold state default /var/lib/rancher/" + version.Program + " or ${HOME}/.rancher/" + version.Program + " if not root",
 				Destination: &ServerConfig.DataDir,
 			},
-			cli.StringSliceFlag{
-				Name:  "cluster-cidr",
-				Usage: "(networking) IPv4/IPv6 network CIDRs to use for pod IPs (default: 10.42.0.0/16)",
-				Value: &ServerConfig.ClusterCIDR,
-			},
-			cli.StringSliceFlag{
-				Name:  "service-cidr",
-				Usage: "(networking) IPv4/IPv6 network CIDRs to use for service IPs (default: 10.43.0.0/16)",
-				Value: &ServerConfig.ServiceCIDR,
-			},
-			cli.StringFlag{
-				Name:        "service-node-port-range",
-				Usage:       "(networking) Port range to reserve for services with NodePort visibility",
-				Destination: &ServerConfig.ServiceNodePortRange,
-				Value:       "30000-32767",
-			},
-			cli.StringSliceFlag{
-				Name:  "cluster-dns",
-				Usage: "(networking) IPv4 Cluster IP for coredns service. Should be in your service-cidr range (default: 10.43.0.10)",
-				Value: &ServerConfig.ClusterDNS,
-			},
-			cli.StringFlag{
-				Name:        "cluster-domain",
-				Usage:       "(networking) Cluster Domain",
-				Destination: &ServerConfig.ClusterDomain,
-				Value:       "cluster.local",
-			},
+			ClusterCIDR,
+			ServiceCIDR,
+			ServiceNodePortRange,
+			ClusterDNS,
+			ClusterDomain,
 			cli.StringFlag{
 				Name:        "flannel-backend",
 				Usage:       "(networking) One of 'none', 'vxlan', 'ipsec', 'host-gw', or 'wireguard'",
@@ -187,21 +209,9 @@ func NewServerCommand(action func(*cli.Context) error) cli.Command {
 				Destination: &ServerConfig.KubeConfigMode,
 				EnvVar:      version.ProgramUpper + "_KUBECONFIG_MODE",
 			},
-			cli.StringSliceFlag{
-				Name:  "kube-apiserver-arg",
-				Usage: "(flags) Customized flag for kube-apiserver process",
-				Value: &ServerConfig.ExtraAPIArgs,
-			},
-			cli.StringSliceFlag{
-				Name:  "kube-scheduler-arg",
-				Usage: "(flags) Customized flag for kube-scheduler process",
-				Value: &ServerConfig.ExtraSchedulerArgs,
-			},
-			cli.StringSliceFlag{
-				Name:  "kube-controller-manager-arg",
-				Usage: "(flags) Customized flag for kube-controller-manager process",
-				Value: &ServerConfig.ExtraControllerArgs,
-			},
+			ExtraAPIArgs,
+			ExtraControllerArgs,
+			ExtraSchedulerArgs,
 			cli.StringSliceFlag{
 				Name:  "kube-cloud-controller-manager-arg",
 				Usage: "(flags) Customized flag for kube-cloud-controller-manager process",

diff --git a/pkg/etcd/etcd.go b/pkg/etcd/etcd.go
@@ -237,7 +237,7 @@ func (e *ETCD) Reset(ctx context.Context, rebootstrap func() error) error {
 				return err
 			}
 			logrus.Infof("Retrieving etcd snapshot %s from S3", e.config.ClusterResetRestorePath)
-			if err := e.s3.download(ctx); err != nil {
+			if err := e.s3.Download(ctx); err != nil {
 				return err
 			}
 			logrus.Infof("S3 download complete for %s", e.config.ClusterResetRestorePath)
@@ -1024,7 +1024,7 @@ func (e *ETCD) listSnapshots(ctx context.Context, snapshotDir string) ([]Snapsho
 // if it hasn't yet been initialized.
 func (e *ETCD) initS3IfNil(ctx context.Context) error {
 	if e.s3 == nil {
-		s3, err := newS3(ctx, e.config)
+		s3, err := NewS3(ctx, e.config)
 		if err != nil {
 			return err
 		}

diff --git a/pkg/etcd/s3.go b/pkg/etcd/s3.go
@@ -31,7 +31,7 @@ type S3 struct {
 // newS3 creates a new value of type s3 pointer with a
 // copy of the config.Control pointer and initializes
 // a new Minio client.
-func newS3(ctx context.Context, config *config.Control) (*S3, error) {
+func NewS3(ctx context.Context, config *config.Control) (*S3, error) {
 	tr := http.DefaultTransport
 
 	switch {
@@ -112,7 +112,7 @@ func (s *S3) upload(ctx context.Context, snapshot string) error {
 
 // download downloads the given snapshot from the configured S3
 // compatible backend.
-func (s *S3) download(ctx context.Context) error {
+func (s *S3) Download(ctx context.Context) error {
 	var remotePath string
 	if s.config.EtcdS3Folder != "" {
 		remotePath = filepath.Join(s.config.EtcdS3Folder, s.config.ClusterResetRestorePath)