print binary size #182
Merged
print binary size #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hish15
reviewed
Jan 31, 2021
cmake/stm32/common.cmake
Outdated
Comment on lines
13
to
23
| if(NOT STM32_TOOLCHAIN_PATH AND NOT CMAKE_C_COMPILER) | ||
| set(STM32_TOOLCHAIN_PATH "/usr") | ||
| message(STATUS "No STM32_TOOLCHAIN_PATH specified, using default: " ${STM32_TOOLCHAIN_PATH}) | ||
| else() | ||
| file(TO_CMAKE_PATH "${STM32_TOOLCHAIN_PATH}" STM32_TOOLCHAIN_PATH) | ||
| if(NOT STM32_TOOLCHAIN_PATH) | ||
| # keep only directory of compiler | ||
| get_filename_component(STM32_TOOLCHAIN_PATH ${CMAKE_C_COMPILER} DIRECTORY) | ||
| # remove the last /bin directory | ||
| get_filename_component(STM32_TOOLCHAIN_PATH ${STM32_TOOLCHAIN_PATH} DIRECTORY) | ||
| endif() | ||
| file(TO_CMAKE_PATH "${STM32_TOOLCHAIN_PATH}" STM32_TOOLCHAIN_PATH) |
There was a problem hiding this comment.
The logic is confusing
if(not a && not b)
else() # if(a or b)
if(not a)
endif()
endif()
There was a problem hiding this comment.
I did my best. What do you propose ?
There was a problem hiding this comment.
What about :
if(not a && not b)
elseif(not a) # the `&& b` not needed but good too
endif()
file(TO_CMAKE_PATH "${STM32_TOOLCHAIN_PATH}" STM32_TOOLCHAIN_PATH)
I think doing the conversion TO_CMAKE_PATH is good either way, so I took it out of the if blocks.
What do you think?
There was a problem hiding this comment.
What's good after 3 month is that I'm stranger to my code and can judge it better. Sorry for delay :)
This was referenced Jun 8, 2021
Merged
Hish15
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #166
The function is called
stm32_print_size_of_targetI also added a small modification so that STM32_TOOLCHAIN_PATH could be set by CMAKE_C_COMPILER. As a VScode user, this is how the compiler is passed to cmake.