Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting paths through env vars #187

Closed
wants to merge 1 commit into from
Closed

Allow setting paths through env vars #187

wants to merge 1 commit into from

Conversation

g-arjones
Copy link
Contributor

This makes integration with some build environments easier (i.e by sourcing an env script)

@g-arjones g-arjones force-pushed the allow_settings_paths_through_env branch 4 times, most recently from 1fd9e3b to ebed0a4 Compare April 16, 2021 03:48
atsju
atsju reviewed Apr 16, 2021
View reviewed changes
Copy link
Collaborator

@atsju atsju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea 👍

cmake/FindFreeRTOS.cmake Show resolved Hide resolved
@g-arjones g-arjones force-pushed the allow_settings_paths_through_env branch from ebed0a4 to 96c1814 Compare April 16, 2021 13:05
@g-arjones
Copy link
Contributor Author

Updated.

@robamu robamu mentioned this pull request Jun 8, 2021
Merged
@atsju
Copy link
Collaborator

atsju commented Jun 23, 2021

Hello @g-arjones I really like the idea of this PR and would like to merge it soon :)
Could you please check if it makes to update the readme so that new users can find and use the feature without digging to much ?

@g-arjones
Copy link
Contributor Author

@atsju I think it does, yes. Unfortunately, since the merge took too long (I'm using this in production) I couldn't wait and have been using a fork for a while now. I'm a bit overwhelmed and can't add documentation. Sorry.

I have enabled edits by maintainers so you are welcome to push docs to this branch if you are still interested in my contribution.

@atsju
Copy link
Collaborator

atsju commented Jun 23, 2021

Thank you for fast and honest response. Maintenance should go a bit faster from now. Maybe you will be able to go back to this repo in a while. I will see how we manage this.

@robamu robamu mentioned this pull request Jul 3, 2021
Merged
@Hish15
Copy link
Collaborator

Hish15 commented Jul 11, 2021

Closing in favor of #226

@Hish15 Hish15 closed this Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atsju atsju atsju left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@g-arjones @atsju @Hish15