Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CMSIS RTOS #189

Closed
wants to merge 1 commit into from

Conversation

g-arjones
Copy link
Contributor

Closes #160

@Hish15
Copy link
Collaborator

Hish15 commented Apr 17, 2021

The message printing is definitely a good adition!
I don't understand why you had to change the whole looping mechanism, you could handle cmsis like any other cmsis component, on the already existing loop.

Another PR could be made to change the whole looping thing to figure out families first, but I don't think this is linked to what is done on this PR.
Also such a good adition deserve to be added to the Readme 👍

@g-arjones
Copy link
Contributor Author

g-arjones commented Apr 17, 2021

Please be more specific about what you think is wrong with the "looping mechanism".

I implemented it like the one in the HAL find script is to make it consistent.

Families are, in fact being figured out first (that's what's changed) so I don't really understand what you would like to see in a different PR.

I will gladly add anything to the README as soon as I have any indication that this will ever get merged.

@Hish15
Copy link
Collaborator

Hish15 commented Apr 17, 2021

You are right, I was not clear on the "looping mechanism" bit sorry.

It is also true that you did exactly as it's done on the HAL part, so it's perfect.
You did more than just add the feature, and it being a single commit made me misjudge the changes.

@Hish15
Copy link
Collaborator

Hish15 commented Jun 24, 2021

Hi @g-arjones, we are now ready to merge some PR 😄
Can you add the related documentation so this features become a feature?

Regards,

@g-arjones
Copy link
Contributor Author

@Hish15 Unfortunately, as I mentioned to @atsju I'm now using a fork of this project in production. I have enabled edits by maintainers in all my PRs so you guys are very welcome to modify them as you see fit in case you are interested in the contribution.

@robamu
Copy link
Contributor

robamu commented Jun 26, 2021

I added documentation om how to use this in my fork. I can create a PR if I find some time soon

@Hish15
Copy link
Collaborator

Hish15 commented Jul 1, 2021

Closing in favor of #222

@Hish15 Hish15 closed this Jul 1, 2021
@robamu robamu mentioned this pull request Jul 4, 2021
robamu added a commit to us-irs/stm32-cmake that referenced this pull request Aug 1, 2021

Unverified

This user has not yet uploaded their public signing key.
Adds the full features set for CMSIS RTOS support, with a lot
work provided by g-arjones. Builds on ObKo#190
and ObKo#189.

It allows to use the CMSIS support provided in the STM32 cube
repository.

Also adds documentation and an updated freertos example with the
same architecture as ObKo#225
robamu added a commit to us-irs/stm32-cmake that referenced this pull request Aug 1, 2021
Adds the full features set for CMSIS RTOS support, with a lot
work provided by g-arjones. Builds on ObKo#190
and ObKo#189.

It allows to use the CMSIS support provided in the STM32 cube
repository.

Also adds documentation and an updated freertos example with the
same architecture as ObKo#225
@robamu robamu mentioned this pull request Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle CMSIS-RTOS and CMSIS-RTOS2 as CMSIS components
3 participants