-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add --all for exit sign command #3272
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3272 +/- ##
==========================================
- Coverage 57.68% 57.64% -0.05%
==========================================
Files 211 211
Lines 30418 30478 +60
==========================================
+ Hits 17547 17569 +22
- Misses 10986 11014 +28
- Partials 1885 1895 +10 ☔ View full report in Codecov by Sentry. |
return errors.Wrap(err, "could not sign exits for all validators") | ||
} | ||
} else { | ||
exitBlobs, err = signSingleValidatorExit(ctx, config, eth2Cl, shares) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use signAllValidatorsExits here, and instead of passing all shares we pass a slice with the single share we're interested in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I've been thinking about that, but when we are signing for single validator we are checking the config if the user passed pubkey or index or both, in exit all scenario we don't have none of those. We can still use the same function for both cases, but I will have to add some flags and checks which to determine if we have to check the config or not. It will make the code less readable imo.
Add `--all` command for signing partial exits. This PR is one of a couple incoming PRs that will be for the `--all` functionality. Mind that the CLI flag is not enabled until all of them are implemented and merged. category: feature ticket: #3243
Add
--all
command for signing partial exits. This PR is one of a couple incoming PRs that will be for the--all
functionality. Mind that the CLI flag is not enabled until all of them are implemented and merged.category: feature
ticket: #3243