cmd: fix test peers out of range #3280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3280 +/- ##
==========================================
+ Coverage 57.63% 57.72% +0.09%
==========================================
Files 211 211
Lines 30418 30420 +2
==========================================
+ Hits 17532 17561 +29
+ Misses 10997 10974 -23
+ Partials 1889 1885 -4 ☔ View full report in Codecov by Sentry. |
pinebit
approved these changes
Sep 12, 2024
KaloyanTanev
added
the
merge when ready
pinebit
pushed a commit
that referenced
this pull request
Sep 16, 2024
After #3267 was merged, on `ctx.Done()` we push the latest unfinished test. This causes out of range in the outer function in some ocassions. category: bug ticket: none
Merged
obol-bulldozer bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
For release v1.1.1 cherry picked: * [core/validatorapi: workaround for Gnosis proposals](#3238) * [*: enable gnosis hotfix automatically](#3257) *: [fix flaky testpeers test #3267](#3267) * [cmd: increase testpeers tests timeouts #3268](#3268) * [cmd: fix test peers out of range #3280](#3280) * [testutil: update docker-compose command to docker compose](#3249) category: misc ticket: none
gsora
pushed a commit
that referenced
this pull request
Sep 18, 2024
After #3267 was merged, on `ctx.Done()` we push the latest unfinished test. This causes out of range in the outer function in some ocassions. category: bug ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #3267 was merged, on
ctx.Done()we push the latest unfinished test. This causes out of range in the outer function in some ocassions.category: bug
ticket: none