fix(dockerfile): optimized Dockerfile #3281
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Dockerfile
Outdated
| @@ -18,33 +26,41 @@ | |||
|
|
|||
| # Copy final binary into light stage. | |||
| FROM debian:bookworm-slim | |||
| RUN apt-get update && apt-get install -y ca-certificates wget fio | |||
| RUN apt-get update && apt-get install -y --no-install-recommends ca-certificates wget fio \ | |||
Check notice
Code scanning / SonarCloud
Arguments in long RUN instructions should be sorted Low
|
No0key
changed the title
Comment on lines
+10
to
+11
| COPY go.mod go.sum ./ | ||
| RUN go mod download |
There was a problem hiding this comment.
This is not necessary as go build will download the dependencies.
| # Install dependencies | ||
| RUN apt-get update && apt-get install -y build-essential git | ||
| RUN apt-get update && apt-get install -y --no-install-recommends build-essential git \ | ||
| && rm -rf /var/lib/apt/lists/* |
There was a problem hiding this comment.
Not necessary, as this is multi-stage build and the image from the first stage is not used in the final image.
Comment on lines
+51
to
+52
| && mkdir -p "/opt/$USER" \ | ||
| && chown "$USER" "/opt/$USER" |
There was a problem hiding this comment.
Not necessary, as the adduser command already created this directory, see --home "/opt/$USER". Its owner is also the said user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This PR optimizes the
Dockerfile.Changes include:
Category: refactor
Reduced image size from 370MB to 302MB