Improve exception types raised and caught #17
Labels
enhancement
New feature or request
Comments
github-project-automation
bot
moved this to Backlog
in Python Client Library Development
Jacob-Stevens-Haas
added a commit
that referenced
this issue
Dec 1, 2023
Fixes #17 Also * modify ONC to accept Path objects for outPath * Modify tests/readme.md for pytest tests Note: Unclear whether some error codes from server should be 127/129. (e.g. test_raw_bad_filters/test_bad_filters). Other services do not list their error codes on the ONC wiki.
Jacob-Stevens-Haas
added a commit
that referenced
this issue
Dec 5, 2023
Fixes #17 Also * modify ONC to accept Path objects for outPath * Modify tests/readme.md for pytest tests Note: Unclear whether some error codes from server should be 127/129. (e.g. test_raw_bad_filters/test_bad_filters). Other services do not list their error codes on the ONC wiki.
github-project-automation
bot
moved this from Backlog
to Done
in Python Client Library Development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See #3. There are 19 cases of
except Exceptionand 11 of `raise Exception. Python's philosophy is to raise the most specific error possible so that exception handlers and humans have the most information possible. The way to achieve this is via:raisestatementsexceptstatements, in case any are untested.In addition, a lot of code uses the antipattern:
which does the same thing as
Out of scope for this issue but also germane is the use of internal status-passing with integer codes, rather than raising an exception.
Ref:
https://docs.python.org/3/library/exceptions.html
The text was updated successfully, but these errors were encountered: