Issue 33 add helper get xxx method #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ome public methods for consistency with OpenAPI page
…e renaming, and hide aliases in the API reference.
…ssing libraries Also removed CI tests on Windows and Mac. GitHub Actions run them in parallel. This is to reduce the workload and speed up the CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #33 DMAS-79712
This PR contains two tasks: add helper method to combine
ByDeviceandByLocation, and rename methods to match the api endpoint.There are still some documentation tasks left for the methods renaming (Readme, Tutorial, Code examples). I will do it after this release when I work on changing the names from camelCase to snake_case (so no duplicate work).
Also no tests were added for the new getXXX methods. Plan to work on it when fixing #31
Added one additional commit for discouraging users from using multiprocessing library. It is out of scope of this PR, but it is a recent issue that caused us some trouble on the server side.