-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecation decorators #1683
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1683 +/- ##
==========================================
+ Coverage 81.10% 81.18% +0.07%
==========================================
Files 70 72 +2
Lines 13197 13256 +59
Branches 127 127
==========================================
+ Hits 10704 10762 +58
- Misses 2456 2457 +1
Partials 37 37
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The creation of the |
b86f524
to
a533f4c
Compare
a533f4c
to
78a857b
Compare
I'm fine with creating this subdirectory; we can move other tests in there too at a later stage |
My motivation for creating the
I didn't quite understand this comment. Do we need to reconsider the folder structure of the tests? |
Maybe it was a bit vague. I meant to say we can reconsider where to put which test files at a later stage. Like what you suggest above, so all fine |
Adds deprecation decorators
@deprecated()
and@deprecated_made_private
. Note the brackets ondeprecated()
when using it. This is because it accepts an optional custom message that is appended to the warning message (to be used to denote an alternative to users, or any other information that may be of use).Note: When using in conjunction with other decorators (e.g.,
@staticmethod
@property
) the deprecation method should be the innermost one (i.e., closest to thedef ...
) so that they're applied first.Examples (updated):
output: