Fixing bug in backward-in-time-writing #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #1722, by reverting a change in ed11e43 Thanks for the git-bisect hint, @VeckoTheGecko!
tests/test_particlesets.py
Outdated
| which for some reason #1722 | ||
| """ | ||
| outputdt = timedelta(hours=1) | ||
| runtime = timedelta(days=2) |
There was a problem hiding this comment.
I encountered a bit of difficulty writing these tests as even here changing runtime to days=1 made the bug go away.
@willirath did you also encounter some difficulty writing your minimal example?
There was a problem hiding this comment.
@willirath did you also encounter some difficulty writing your minimal example?
No, I basically posted exactly the code that let me discover the bug. So maybe I was just "lucky".
VeckoTheGecko
approved these changes
Oct 7, 2024
erikvansebille
commented
Oct 7, 2024
|
I think we can benefit with a refactor of We plan to do a patch release where the only difference from v3.0.5 is fixing this bug. Plan:
|
Test discovery wasn't working as intended. Error was only in main for 5 days (so no release affected)
VeckoTheGecko
force-pushed
the
fixing_backwardtime_writing_bug
branch
from
ceed3c1 to
8be1e92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1722, by reverting a change in ed11e43
Thanks for the git-bisect hint, @VeckoTheGecko!