Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Field tests to separate file #1821

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Move Field tests to separate file #1821

merged 2 commits into from
Jan 10, 2025

Conversation

VeckoTheGecko
Copy link
Contributor

Just think its clearer to have test_fieldset.py not include tests specifically for Field

erikvansebille
erikvansebille approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@erikvansebille erikvansebille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to separate out, indeed

tests/test_advection.py Show resolved Hide resolved
@VeckoTheGecko VeckoTheGecko merged commit 02eb9a7 into main Jan 10, 2025
15 of 16 checks passed
@VeckoTheGecko VeckoTheGecko deleted the v/test-suite branch January 10, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikvansebille erikvansebille erikvansebille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Parcels development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VeckoTheGecko @erikvansebille