Fix broken scroll behaviour on index and profile page #2487
Conversation
I don't know where the bug originates. But it can only be that either `previousResult` or `fetchMore` result is sometimes undefined. This should make the function bullet-proof for these situations.
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
![cypress[bot]](https://avatars1.githubusercontent.com/u/38261864?s=88&v=4){kind=small}
maybe, we should test it out in staging? it certainly doesn't seem to hurt, but maybe you want to have another stab at it? |
@mattwr18 I didn't see your comment. This problem is not being solved with this PR. Instead, on my browser, sometimes the scroll would hang. That is the case when you have runtime errors during |
The problem of your screenshot is not that scrolling simply stops. Instead, new posts are getting added all the time and since they don't have a height, the scrolling gets triggered all the time. Like many times in short succession. |
I don't know where the bug originates. But it can only be that either
previousResultorfetchMoreresult is sometimes undefined. Thisshould make the function bullet-proof for these situations.
🍰 Pullrequest
Issues
Todo