Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update it.json #2507

Closed
wants to merge 1 commit into from
Closed

Update it.json #2507

wants to merge 1 commit into from

Conversation

Tirokk
Copy link
Member

@Tirokk Tirokk commented Oct 5, 2020

erhardtstiefel Authored by erhardtstiefel
Dec 13, 2019
Merged Dec 13, 2019


I added the missing italian verbs just for the display of "donations" but I see a lot more verbs missing. Does it make sense to translate everything to be found in en.json and fill in it.json?

🍰 Pullrequest

Issues

  • None

Todo

  • None

I added the missing italian verbs just for the display of "donations" but I see a lot more verbs missing. Does it make sense to translate and  fill in everything which is to be found in en.json ?
@Tirokk
Copy link
Member Author

Tirokk commented Oct 7, 2020

cypress[bot] Authored by cypress[bot]
Dec 13, 2019




Test summary

50 0 0 0


Run details

Project Human-Connection
Status Passed
Commit 03ba3be934
Started Dec 13, 2019 4:02 PM
Ended Dec 13, 2019 4:16 PM
Duration 14:07 💡
OS Linux Ubuntu Linux - 16.04
Browser Chromium 79

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@Mogge Mogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot review this PR properly, because I'm not very proficient in Italian. @erhardtstiefel I just trust you that this text is alright.

In general, I think I'm more than happy to change translations if the text is just misleading. E.g.. "Delete User" instead of just "Delete your data" and their counterparts in our languages. I'm more patient for the translations that are not urgent.

@erhardtstiefel do you know https://lokalise.com/projects ? That's our platform where native speakers can translate our application without the need of going through Github. @Mogge can tell you a lot about lokalise.

I'm going to merge this as it is not too much text and the risk is low even if there are some mistakes in it.

@Mogge Mogge closed this Oct 8, 2020
@ulfgebhardt ulfgebhardt deleted the pr2507head branch January 7, 2021 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants