Update neode #2539
Update neode #2539
Conversation
This fixes some API changes with the update of neode.
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
| @@ -40,7 +40,7 @@ export default { | |||
| `, | |||
| { nonce, email }, | |||
| ) | |||
| const emailAddress = await neode.hydrateFirst(result, 'email', neode.model('Email')) | |||
| const emailAddress = await neode.hydrateFirst(result, 'email', neode.model('EmailAddress')) | |||
| if (!emailAddress) throw new UserInputError('Invalid email or nonce') | |||
There was a problem hiding this comment.
Authored by mattwr18
Dec 17, 2019
Outdated (history rewrite) - original diff
@@ -40,7 +40,7 @@ export default {
`,
{ nonce, email },
)
- const emailAddress = await neode.hydrateFirst(result, 'email', neode.model('Email'))
+ const emailAddress = await neode.hydrateFirst(result, 'email', neode.model('EmailAddress'))
if (!emailAddress) throw new UserInputError('Invalid email or nonce')what would we have to do to remove neode from production code?
This is one of the only remaining resolvers which uses it...
There was a problem hiding this comment.
Dec 17, 2019
The fact that @johnymontana considers using neode in neo4j-graphql-js is making me unsure about if we should try to refactor neode out of our production code.
🍰 Pullrequest
See Human-Connection/Human-Connection#1913
This also fixes a bug along the way (wrong model name). And we have to format the validation to send them back to the client.