fix(jwt): Whitelist encoded JWT attributes #3090
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will prevent unintentional encoding of users email addresses in the JWT. @steffi201028 this might be interesting for you as well.
I don't know but maybe that might also fix our stalling builds. After all, we |
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Tirokk
commented
Oct 7, 2020
| } | ||
| }) | ||
|
|
||
| it('encodes a valided JWT bearer token', () => { |
There was a problem hiding this comment.
Authored by mattwr18
Feb 18, 2020
Outdated (history rewrite) - original diff
@@ -0,0 +1,62 @@
+import encode from './encode'
+import jwt from 'jsonwebtoken'
+import CONFIG from './../config'
+
+describe('encode', () => {
+ let payload
+ beforeEach(() => {
+ payload = {
+ name: 'Some body',
+ slug: 'some-body',
+ id: 'some-id',
+ }
+ })
+
+ it('encodes a valided JWT bearer token', () => {
Suggested change
| it('encodes a valided JWT bearer token', () => { | |
| it('encodes a valid JWT bearer token', () => { |
normally, I would suggest this change, but with the build server so difficult to get passing, I think we can make this change some other time
Mogge
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent unintentional encoding of users email addresses in the
JWT.
@steffi201028 this might be interesting for you as well.
🍰 Pullrequest
Issues
Todo