fix: Text of editor embeds disappearing on click [2727]

[Tirokk]

Authored by rbeer
Mar 27, 2020
Merged Apr 16, 2020

---

🍰 Pullrequest

Problem

EmbedComponent is inserted as editor content (inside <p>) and selected with a NodeSelection @click.

Changing the schema of the Embed Node has no effect for

• selectable: false
• atom: true
• marks: ''

(see prosemirror NodeSpec)

Workaround

fbcc10e - Prevent selection in entire embed element. This has the obvious downside that no content can be selected for e.g. copying.

Packages

• tiptap
  • prosemirror editor

Issues

• fixes 🐛 [Bug] If you click the text inside an embed, the text disappears #2727

Todo

• find solution, i.e. learn how Prosemirror works

[Tirokk]

Authored by cypress[bot]
Mar 31, 2020

---

---

Test summary

66 • 0 • 0 • 0

---

Run details

Project	Human-Connection
Status	Passed
Commit	5fad066
Started	Apr 2, 2020 12:35 AM
Ended	Apr 2, 2020 12:55 AM
Duration	20:27 💡
OS	Linux Ubuntu Linux - 16.04
Browser	Firefox 68

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[Tirokk]

Authored by cypress[bot]
Mar 31, 2020

---

---

Test summary

66 • 0 • 0 • 0

---

Run details

Project	Human-Connection
Status	Passed
Commit	9621d09c6a ℹ️
Started	Apr 2, 2020 12:36 AM
Ended	Apr 2, 2020 1:01 AM
Duration	24:45 💡
OS	Linux Ubuntu Linux - 16.04
Browser	Firefox 68

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[Tirokk]

Authored by rbeer
Apr 2, 2020

---

I suggest we merge this quickfix (i.e. using the selectable: false flag of prosemiror) to the bug and open another PR for #3395, looking into the overall Embed problem.