feat: 🍰 Alphabetically sorting tags using compute functions on index and more… #3589
Conversation
…-info page. Added test checking tags are present and shown alphabetically.
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
| @@ -143,5 +144,48 @@ describe('PostSlug', () => { | |||
| }) | |||
| }) | |||
| }) | |||
|
|
|||
| describe('tags shown in tag cloud', () => { | |||
There was a problem hiding this comment.
Authored by Tirokk
Jun 3, 2020
Outdated (history rewrite) - original diff
@@ -143,5 +144,48 @@ describe('PostSlug', () => {
})
})
})
+
+ describe('tags shown in tag cloud', () => {Nicely done 😍
Thanks for testing! 👍🏼
| @@ -179,6 +183,9 @@ export default { | |||
| if (!author) return false | |||
| return this.$store.getters['auth/user'].id === author.id | |||
| }, | |||
| sortedTags() { | |||
There was a problem hiding this comment.
Jun 3, 2020
Outdated (history rewrite) - original diff
@@ -179,6 +179,20 @@ export default {
if (!author) return false
return this.$store.getters['auth/user'].id === author.id
},
+ sortedTags() {I would love to have this imported as a more general function located in components/utils/PostHelpers or even in a more general utility file.
This way it can be reused in webapp/pages/post/_id/_slug/more-info.vue. 👇🏼
It can be used to sort the post categories in the future. 🙏🏼
A missing issue as far as I see …
| @@ -62,6 +63,9 @@ export default { | |||
| post() { | |||
| return this.Post ? this.Post[0] || {} : {} | |||
| }, | |||
| sortedTags() { | |||
There was a problem hiding this comment.
Jun 3, 2020
Outdated (history rewrite) - original diff
@@ -62,6 +62,20 @@ export default {
post() {
return this.Post ? this.Post[0] || {} : {}
},
+ sortedTags() {Would be nice to have a shared function … see above ☝🏼
@Tirokk I moved the sorting function to the I could indeed make a new file |
There was a problem hiding this comment.
Hey @DriesCruyskens ,
great that you cared for this as well. 💫🚀
Well done! Works very good for me and glad you wrote a test. 😍
Only some little changes I suggested …
There was a problem hiding this comment.
Hey @DriesCruyskens !
I’m graceful that you spend your time again to our project. 🙏🏼
Nice work ! 💫🚀
I approve!
…ud-alphabetically feat: 🍰 Alphabetically sorting tags using compute functions on index and more…
…-info page. Added test checking tags are present and shown alphabetically.
🍰 Pullrequest
Sorting happens in computed functions, seems like the Vue way to do it. It could also be done once in
apollo'supdatefunction. Let me know what you think.Main post page:
More info:
Issues
Todo