feat(webapp): 🍰 allows mark all notifications as read #3922

ftonato · 2020-10-25T15:17:22Z

🍰 Pullrequest

This pull-request will allows all the users mark all notifications as read with one click

Preview:

Issues

fixes 🚀 [Feature] Notifications – Mark All As Read #2660

Todo

backend:
- mutation: have a singe mutation with both functionallities in markAsRead?
  - instead of extra mutation markAllAsRead
  - especially because for paginated notification list we may just want to mark a given array of IDs as read
webapp:
- tests: only the frontend unit test is missing
clean up: search for Wolle

- Add mutation for markAllAsRead (notifications) - Add method to the schema that returns a list of all notifications - Add permissions rules to invoke this method (isAuthenticated) See #2660

Tirokk · 2020-10-26T07:25:31Z

Hey @ftonato ,
your are invited now.
Sorry. Don’t know why I got over that. 😅

Please push after your acceptation again …

ftonato · 2020-10-27T10:58:46Z

Hello,
Could some one take a look and try to figure out why my unit tests are not passing?

Tirokk · 2020-10-27T15:52:37Z

Sorry @ftonato !
The tests are not fully implemented yet, because I had so many other things to do.
I implement the tests these days. They fail, because of wrong settings and secrets … hope I get it done tomorrow.

BUT:

One thing I see is …

$ ./scripts/translations/sort.sh
de.json is not sorted by keys
en.json is not sorted by keys
es.json is not sorted by keys
fr.json is not sorted by keys
it.json is not sorted by keys
nl.json is not sorted by keys
pt.json is not sorted by keys
ru.json is not sorted by keys
The command "./scripts/translations/sort.sh" exited with 1.
$ ./scripts/translations/missing-keys.sh

The locales are tested with the command:

# in webapp folder
$ yarn locales

Or fixed by command:

# in webapp folder
$ yarn locales --fix

The entries in the locales have to be in alphabetical order and german language (second base) has to have the same entries as english (base).

Linting

In think you already know …

The linting is tested:

# in webapp and backend folder
$ yarn lint

Or fixed by:

# in webapp and backend folder
$ yarn lint --fix

Tomorrow

I can give you a review tomorrow.

ftonato · 2020-10-27T20:15:48Z

I already passed by all these steps, but seems still not working =(

Tirokk · 2020-10-29T18:50:14Z

Hey @ftonato ,
sorry for not caring. I have to help somebody as an emergency who has problems with corona in his family. Because of this and other things unfortunately I need til Monday to find time for your PR. 😓

- And added some empty lines for nice formating.

Tirokk

Hey @ftonato ,

really cool and sophisticated first through !!! 🚀💫

I did some comments and suggestions and there are some little questions open.
Please let me know if I can be of some help for clarifications.

PS: I have merge the master, have corrected one test, which I have tried to corrected successfully, and added some empty lines …
Pushed onto your PR. Hope that is okay?

backend/src/schema/resolvers/notifications.js

backend/src/schema/resolvers/notifications.spec.js

webapp/components/NotificationMenu/NotificationMenu.vue

webapp/locales/nl.json

webapp/pages/notifications/index.vue

webapp/pages/notifications/index.spec.js

Tirokk · 2020-11-02T15:58:38Z

Sorry, tests are still not working …

Tirokk · 2020-11-04T09:20:24Z

Now the Travis tests should work … @ftonato

ftonato · 2020-11-05T20:47:45Z

Hey @Tirokk,

I'm not sure about the reason, but since I did git pull to get your commit (merge with master) I can't run the app.

See the image below please:

Tirokk · 2020-11-09T10:56:09Z

Hey @ftonato ,
I pulled your branch with reset --hard so that’s really your code.
I had not the error you mentioned above.

Can you try yarnor yarn install in your webapp? And then yarn dev again?

There are some errors in webapp tests in file pages/notifications/index.spec.js …
Did they run on your machine?

What do you think about my suggestions in relation to the style and design?

PS: I fixed the linting …

…celot-Social into feature/mark-all-notification-as-read-test

I overtake myself

ftonato · 2023-02-23T09:56:30Z

I'm closing outdated issues and pull-requests that are no longer relevant given how much time has passed since they were opened.

Tirokk · 2023-02-23T17:05:09Z

Sorry @ftonato this is still relevant.

The project gets much more financing and activity now.
In case you are interessted you are welcome. 🤗

Shall I unassign you in case you getting notifications you don't want?

ftonato · 2023-02-23T17:12:46Z

Don't worry, we can keep it open then.

I was assuming, since it's an old pull-request, that it wasn't updated and therefore it would be useless to keep it open (my fault, sorry)...

Note: I have a script that parses all my old issues/pull requests and closes it for me with the default message ^^

Tirokk · 2023-02-24T12:37:34Z

Okidoki 👍🏼
@ftonato

Tirokk

Hey @Mogge ,

cool that you brought that issue to an end. @Mogge

Thanks a lot for your effort and contribution to ocelot.social so long ago @ftonato !!! 🙏🏼
The project now takes big steps forward.

I approve 🚀🚀💫💫

ftonato added 6 commits October 24, 2020 11:29

feat: add mutation for new functionality (mark-all-as-read)

0bffede

- Add mutation for markAllAsRead (notifications) - Add method to the schema that returns a list of all notifications - Add permissions rules to invoke this method (isAuthenticated) See #2660

feat: add translations for notifications label (mark all as read)

e37fb53

feat: add tests for mark all as read (backend)

1df69c9

feat: add button to mark all notifications as read on notification menu

bfe66ad

feat: add button to mark all notifications as read on notification page

d831e14

feat: add tests for mark all as read (webapp)

4a23087

ftonato requested review from Mogge and Tirokk and removed request for Mogge October 27, 2020 10:58

refactor: updating locales in alphabetical order

cc99e27

Tirokk assigned ftonato Oct 29, 2020

Tirokk changed the title ~~[WIP] Allows mark all notifications as read~~ [WIP] 🍰 Allows Mark All Notifications As Read Nov 2, 2020

Tirokk changed the title ~~[WIP] 🍰 Allows Mark All Notifications As Read~~ feat: [WIP] 🍰 Allows Mark All Notifications As Read Nov 2, 2020

Correct backend test

ae4f53e

- And added some empty lines for nice formating.

Tirokk previously requested changes Nov 2, 2020

View reviewed changes

Tirokk and others added 5 commits November 12, 2020 15:37

Merge branch 'master' of https://github.com/Ocelot-Social-Community/O…

a94d718

…celot-Social into feature/mark-all-notification-as-read-test

fix: update based on code-review suggestions

89e0340

fix: update based on code-review suggestions

7f345c3

fix: update tests for markAllAsRead

e1ef6f8

Fix linting

b404355

Tirokk added 4 commits November 16, 2022 14:14

Fix template slot notation

8234615

Add 'pl' translation

4ebae57

Refine 'NotificationMenu.vue'

61effbe

Refine notifications page

d26c37a

Move GQL in notification tests in separate file

f63a12d

ulfgebhardt removed the request for review from Mogge November 17, 2022 10:26

ulfgebhardt unassigned Mogge Nov 17, 2022

ulfgebhardt modified the milestones: 🏃 22/11 November, 🏃 22/12 December Dec 5, 2022

ulfgebhardt modified the milestones: 🏃 22/12 December, 🏃 23/01 January Jan 4, 2023

ftonato closed this Feb 23, 2023

Tirokk reopened this Feb 23, 2023

Tirokk assigned Mogge and unassigned Tirokk Feb 27, 2023

Mogge added 3 commits March 8, 2023 16:50

Merge branch 'master' into feature/mark-all-notification-as-read

bdc1cb3

fix typo

b64e35c

refresh notifications after mark all as read, fix tests

c865b72

Mogge changed the title ~~feat(webapp): [WIP] 🍰 allows mark all notifications as read~~ feat(webapp): 🍰 allows mark all notifications as read Mar 8, 2023

Mogge requested review from Mogge and removed request for Mogge March 8, 2023 17:16

Tirokk approved these changes Mar 9, 2023

View reviewed changes

Merge branch 'master' into feature/mark-all-notification-as-read

5bd8317

Mogge merged commit 0634a08 into master Mar 9, 2023

Mogge deleted the feature/mark-all-notification-as-read branch March 9, 2023 12:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(webapp): 🍰 allows mark all notifications as read #3922

feat(webapp): 🍰 allows mark all notifications as read #3922

ftonato commented Oct 25, 2020 •

edited by Mogge

Loading

Tirokk commented Oct 26, 2020

ftonato commented Oct 27, 2020

Tirokk commented Oct 27, 2020 •

edited

Loading

ftonato commented Oct 27, 2020

Tirokk commented Oct 29, 2020

Tirokk left a comment

Tirokk commented Nov 2, 2020

Tirokk commented Nov 4, 2020

ftonato commented Nov 5, 2020

Tirokk commented Nov 9, 2020 •

edited

Loading

ftonato commented Feb 23, 2023

Tirokk commented Feb 23, 2023

ftonato commented Feb 23, 2023 •

edited

Loading

Tirokk commented Feb 24, 2023

Tirokk left a comment

feat(webapp): 🍰 allows mark all notifications as read #3922

feat(webapp): 🍰 allows mark all notifications as read #3922

Conversation

ftonato commented Oct 25, 2020 • edited by Mogge Loading

🍰 Pullrequest

Issues

Todo

Tirokk commented Oct 26, 2020

ftonato commented Oct 27, 2020

Tirokk commented Oct 27, 2020 • edited Loading

Linting

Tomorrow

ftonato commented Oct 27, 2020

Tirokk commented Oct 29, 2020

Tirokk left a comment

Choose a reason for hiding this comment

Tirokk commented Nov 2, 2020

Tirokk commented Nov 4, 2020

ftonato commented Nov 5, 2020

Tirokk commented Nov 9, 2020 • edited Loading

ftonato commented Feb 23, 2023

Tirokk commented Feb 23, 2023

ftonato commented Feb 23, 2023 • edited Loading

Tirokk commented Feb 24, 2023

Tirokk left a comment

Choose a reason for hiding this comment

ftonato commented Oct 25, 2020 •

edited by Mogge

Loading

Tirokk commented Oct 27, 2020 •

edited

Loading

Tirokk commented Nov 9, 2020 •

edited

Loading

ftonato commented Feb 23, 2023 •

edited

Loading