Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock Cookie In Auth.test.js #4119

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Mock Cookie In Auth.test.js #4119

merged 1 commit into from
Jan 7, 2021

Conversation

Mogge
Copy link
Contributor

@Mogge Mogge commented Jan 7, 2021

🍰 Pullrequest

The cookie test must be mocked to get the test running again

Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @Mogge that you and @ulfgebhardt solved the failing tests !!! 🌟🌟🌟

Thank for fixing this!

I have to admit that I do not closely understand how this functions. I have just an idea.
Nevertheless I will approve, because I trust your deeper understanding.

@Tirokk Tirokk merged commit 156d54e into master Jan 7, 2021
@Tirokk Tirokk deleted the fix-cookie-test branch January 7, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants