Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Invite codes #4125

Merged
merged 9 commits into from
Jan 20, 2021
Merged

feat: Invite codes #4125

merged 9 commits into from
Jan 20, 2021

Conversation

Mogge
Copy link
Contributor

@Mogge Mogge commented Jan 11, 2021

🍰 Pullrequest

Backend part for using invite codes for user registration

@ulfgebhardt ulfgebhardt added this to the 21/01 January milestone Jan 14, 2021
@ulfgebhardt
Copy link
Member

As far as I can see our change we did together is missing?! @Mogge

@Mogge Mogge changed the title WIP: Invite codes feat: Invite codes Jan 14, 2021
@Mogge
Copy link
Contributor Author

Mogge commented Jan 14, 2021

What changes do you mean @ulfgebhardt ?

ulfgebhardt
ulfgebhardt previously requested changes Jan 17, 2021
View reviewed changes
Copy link
Member

@ulfgebhardt ulfgebhardt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Just a few pit falls.

  • Ascii encoding incorrect?
  • Lower caps Codes acceptance?

backend/src/schema/resolvers/helpers/generateInviteCode.js Show resolved Hide resolved
backend/src/schema/resolvers/inviteCodes.js Outdated Show resolved Hide resolved
backend/src/schema/resolvers/inviteCodes.spec.js Show resolved Hide resolved
Tirokk
Tirokk approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@Tirokk Tirokk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah @Mogge
This is an important peace of work to reach our GO LIVE! 🚀🚀💫

Great and sustainable work you have done.
I suggested just some easy changes and asked some not as important questions …

Wisdom

backend/src/db/factories.js Outdated Show resolved Hide resolved
backend/src/db/factories.js Outdated Show resolved Hide resolved
backend/src/db/factories.js Show resolved Hide resolved
backend/src/schema/resolvers/inviteCodes.js Outdated Show resolved Hide resolved
backend/src/schema/resolvers/inviteCodes.js Show resolved Hide resolved
backend/src/schema/resolvers/inviteCodes.js Show resolved Hide resolved
backend/src/schema/types/type/InviteCode.gql Outdated Show resolved Hide resolved
backend/src/schema/types/type/InviteCode.gql Outdated Show resolved Hide resolved
@Mogge Mogge dismissed ulfgebhardt’s stale review January 20, 2021 11:46

All changes required are done

@Mogge Mogge merged commit 8a4f64e into master Jan 20, 2021
@Mogge Mogge deleted the invite-codes branch January 20, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tirokk Tirokk Tirokk approved these changes

@ulfgebhardt ulfgebhardt ulfgebhardt left review comments

Assignees

@Mogge Mogge

Labels
feature service: backend
Projects
None yet
Milestone
🏃 21/01 January
Development

Successfully merging this pull request may close these issues.
3 participants
@Mogge @ulfgebhardt @Tirokk