Refactor config #4133
Merged
Refactor config #4133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mogge
previously requested changes
Jan 22, 2021
There was a problem hiding this comment.
First of all, I get the following warning when starting webapp:
ERROR [HPM] Missing "target" option. Example: {target: "http://www.example.org"} 14:11:47
at Object.createConfig (node_modules/http-proxy-middleware/lib/config-factory.js:43:11)
at new HttpProxyMiddleware (node_modules/http-proxy-middleware/lib/index.js:17:30)
at module.exports (node_modules/http-proxy-middleware/index.js:4:10)
at node_modules/@nuxtjs/proxy/lib/module.js:63:30
at Array.forEach (<anonymous>)
at ModuleContainer.proxyModule (node_modules/@nuxtjs/proxy/lib/module.js:61:9)
at ModuleContainer.addModule (node_modules/@nuxt/core/dist/core.js:215:34)
at ModuleContainer.requireModule (node_modules/@nuxt/core/dist/core.js:133:17)
at ModuleContainer.axiosModule (node_modules/@nuxtjs/axios/lib/module.js:106:10)
at ModuleContainer.addModule (node_modules/@nuxt/core/dist/core.js:215:34)
This message is new.
I can reach localhost:3000 but have the following new warnings inn the console:
[Vue warn]: Error in render: "TypeError: this.notifications is undefined"
TypeError: this.notifications is undefined
I can not login!
Error Network error: JSON.parse: unexpected character at line 1 column 1 of the JSON data
As far as I can see, the backend is running fine (port 4000 and tests) but the webapp is not running (although the tests pass).
ulfgebhardt
force-pushed
the
refactor_config
branch
from
fce2302 to
68a8ba5
Compare
|
Good catch! It's fixed |
- default for STYLEGUIDE_DEV config
ulfgebhardt
force-pushed
the
refactor_config
branch
from
7fde4d8 to
a6bd428
Compare
Mogge
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
Refactor the config handling for front- and backend.
Issues
Todo