feat: 🍰 Switch User Role As Admin #4136
Conversation
|
Can an admin change her own role? This way we could avoid easily that at least one admin is remaining. |
…ial-Community/Ocelot-Social into 4124-switch-user-role
…ial-Community/Ocelot-Social into 4124-switch-user-role
webapp/graphql/admin/Roles.js
Outdated
|
|
||
| export const updateUserRole = (role, id) => { | ||
| return gql` | ||
| mutation { |
There was a problem hiding this comment.
Better this way:
mutation($role: UserGroup!, $id: ID!) {
switchUserRole(role: $role, id: $id) {
So we have the schema correctly in the frontend
There was a problem hiding this comment.
Please have two spaces as indentation
There was a problem hiding this comment.
If you could solve this by following @Mogge suggestion … @tippanamadhusudan
| @@ -48,6 +48,23 @@ | |||
| <template #createdAt="scope"> | |||
| {{ scope.row.createdAt | dateTime }} | |||
| </template> | |||
|
|
|||
| <template slot="role" slot-scope="scope"> | |||
There was a problem hiding this comment.
Great! I really like the way you are using slots here!
webapp/pages/admin/users.vue
Outdated
| <ApolloQuery :query="FetchAllRoles"> | ||
| <template v-slot="{ result: { data } }"> | ||
| <template v-if="data"> | ||
| <select |
There was a problem hiding this comment.
Did you try ds-select to get the standard layout for select fields?
There was a problem hiding this comment.
… and try this as well @tippanamadhusudan
|
@tippanamadhusudan I added the tests to the backend. I also made sure, that the current user cannot change the own role to make sure that there is always at least one admin left. May be you can catch this in the frontend as well. The backend throws an error when current user tries to change the own role. |
Tirokk
changed the title
There was a problem hiding this comment.
Hey @tippanamadhusudan ,
your first PR is close to get merged into the master !!! 😍
And it’s a really important one, because we need it urgent for the first network wir.social going online at the beginning of next week! 🚀🚀💫
If you could follow @Mogge suggestions 👇🏼 you have it quickly ready. 🙏🏼💪🏼
Thank you very much for helping !!! 🍀
webapp/graphql/admin/Roles.js
Outdated
|
|
||
| export const updateUserRole = (role, id) => { | ||
| return gql` | ||
| mutation { |
There was a problem hiding this comment.
If you could solve this by following @Mogge suggestion … @tippanamadhusudan
webapp/pages/admin/users.vue
Outdated
| <ApolloQuery :query="FetchAllRoles"> | ||
| <template v-slot="{ result: { data } }"> | ||
| <template v-if="data"> | ||
| <select |
There was a problem hiding this comment.
… and try this as well @tippanamadhusudan
Mogge
changed the title
There was a problem hiding this comment.
You both got it together !!!
A big thank to @tippanamadhusudan !!! This will go into our first live version of ocelot.social: wir.social next week.
Congratulations !!! 🚀🚀💫💫
… and to @Mogge as well for sure! 😘
Just a little hint … 👇🏼
webapp/pages/admin/users.spec.js
Outdated
| }, | ||
| }), | ||
| ) | ||
| // await expect(mocks.$toast.success).toHaveBeenCalled() |
There was a problem hiding this comment.
May delete that comment in favour of the next test?
| update({ __type }) { | ||
| return __type.enumValues.map((item) => item.name) | ||
| }, |
…celot-Social into 4124-switch-user-role
ulfgebhardt
force-pushed
the
4124-switch-user-role
branch
from
8b7570d to
dd8f32b
Compare
🍰 Pullrequest
An admin can change the role a user has
Issues
Todo