-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean GitHub folder #4194
Clean GitHub folder #4194
Conversation
…low in the future - removed clutter from test workflow file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Nice changes! @ulfgebhardt
I appreciate you caring !!! 🚀🚀💫🌟
I would suggest to leave the semantic PR YAML in. See comment …
Everything else looks good to me!
# Always validate the PR title, and ignore the commits | ||
titleOnly: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you remove this? @ulfgebhardt
If you remove it then the semantic-PR fails if you have just one commit. One needs then at least two commits what is mind stretching.
I suggest to leave it in …
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or have you switch the semantic-PR off?
If so, please tell me why you don’t want them. They give a better order in the change log as far I remember …
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand semantic pr, can you elaborate on that? I have not switched anything off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be an addon, not default github standard.
There is two approaches:
- github actions: https://github.com/marketplace/actions/semantic-pull-request
- github app: https://github.com/apps/semantic-pull-requests
I think this might be nice for the changelog, but its definitely not working at the moment.
@Tirokk Please make an Issue to enable it - then we should do a reconfigure anyways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And yet another step forward. Thank you so much.
🍰 Pullrequest
Just some cleanups of the
.github
folder in preparation for implementing a publish workflowIssues
Todo