Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean GitHub folder #4194

Merged
merged 3 commits into from
Feb 5, 2021
Merged

Clean GitHub folder #4194

merged 3 commits into from
Feb 5, 2021

Conversation

ulfgebhardt
Copy link
Member

🍰 Pullrequest

Just some cleanups of the .github folder in preparation for implementing a publish workflow

Issues

  • None

Todo

  • None

Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Nice changes! @ulfgebhardt
I appreciate you caring !!! 🚀🚀💫🌟

I would suggest to leave the semantic PR YAML in. See comment …

Everything else looks good to me!

Comment on lines -1 to -2
# Always validate the PR title, and ignore the commits
titleOnly: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you remove this? @ulfgebhardt
If you remove it then the semantic-PR fails if you have just one commit. One needs then at least two commits what is mind stretching.

I suggest to leave it in …

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or have you switch the semantic-PR off?
If so, please tell me why you don’t want them. They give a better order in the change log as far I remember …

Copy link
Member Author

@ulfgebhardt ulfgebhardt Feb 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand semantic pr, can you elaborate on that? I have not switched anything off.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be an addon, not default github standard.

There is two approaches:

I think this might be nice for the changelog, but its definitely not working at the moment.
@Tirokk Please make an Issue to enable it - then we should do a reconfigure anyways.

Copy link
Contributor

@Mogge Mogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And yet another step forward. Thank you so much.

@ulfgebhardt ulfgebhardt merged commit 16f3a26 into master Feb 5, 2021
@ulfgebhardt ulfgebhardt deleted the clean_github_folder branch February 5, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants