Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🍰 Count Post Views #4248

Merged
merged 10 commits into from
Mar 1, 2021
Merged

feat: 🍰 Count Post Views #4248

merged 10 commits into from
Mar 1, 2021

Conversation

Mogge
Copy link
Contributor

@Mogge Mogge commented Feb 22, 2021

🍰 Pullrequest

Count the number of clicks for posts.

@Mogge Mogge changed the title feat: [WIP] Count Post Views feat: Count Post Views Feb 22, 2021
@Tirokk Tirokk changed the title feat: Count Post Views feat: 🍰 Count Post Views Feb 23, 2021
@ulfgebhardt ulfgebhardt added this to the 21/02 February milestone Feb 25, 2021
ulfgebhardt
ulfgebhardt requested changes Feb 25, 2021
View reviewed changes
Copy link
Member

@ulfgebhardt ulfgebhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • One thing I do not understand (see specific review)
  • No tests on the frontend (?)

backend/src/middleware/userInteractions.js Show resolved Hide resolved
Tirokk
Tirokk approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Mogge !
We are heading into the future. 🚀🚀🚀

@Mogge Mogge merged commit 88fd83e into master Mar 1, 2021
@Mogge Mogge deleted the count-post-views branch March 1, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tirokk Tirokk Tirokk approved these changes

@ulfgebhardt ulfgebhardt ulfgebhardt approved these changes

Assignees

@Mogge Mogge

Labels
devops service: backend service: webapp
Projects
None yet
Milestone
🏃 21/03 March
Development

Successfully merging this pull request may close these issues.
3 participants
@Mogge @ulfgebhardt @Tirokk