Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Fix Wrong Truncation Of Hashtags In Admin List Via Adding 'truncateStr' #4314

Merged
merged 3 commits into from
Mar 30, 2021

Conversation

Tirokk
Copy link
Member

@Tirokk Tirokk commented Mar 29, 2021

🍰 Pullrequest

Fix wrong truncation of hashtags in admin list via adding ‚truncatestr‘.

  • The further used 'truncate' function uses 'trunc-html' which does not function correctly in this case. @Mogge guessed that 'trunc-html‘ does not truncate in the middle of words, but whole words. This can't be correct here!

Issues

Todo

  • None

- Because the 'truncate' function uses 'trunc-html' which seem not to function anymore like expected what has to be investigated further.
@Tirokk Tirokk self-assigned this Mar 29, 2021
@Tirokk Tirokk added service: webapp bug Something isn't working labels Mar 29, 2021
@Tirokk Tirokk requested review from Mogge and ulfgebhardt March 29, 2021 11:04
Copy link
Contributor

@Mogge Mogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Can we test it?

@Tirokk
Copy link
Member Author

Tirokk commented Mar 30, 2021

For sure you can test it @Mogge .
Please let me know if I can merge …

…celot-Social into 4253-long-hashtags-not-visible

# Conflicts:
#	webapp/plugins/vue-filters.js
@Tirokk Tirokk merged commit 8bd34f9 into master Mar 30, 2021
@Tirokk Tirokk deleted the 4253-long-hashtags-not-visible branch March 30, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working service: webapp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Long Hashtag Name In Hashtag List Is Not Visible
3 participants