Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Email Confirmation-Link When An Invite-Code Is Given #4336

Merged
merged 5 commits into from
Apr 6, 2021
Merged

fix: Email Confirmation-Link When An Invite-Code Is Given #4336

merged 5 commits into from
Apr 6, 2021

Conversation

Mogge
Copy link
Contributor

@Mogge Mogge commented Apr 2, 2021 •
edited
Loading

🍰 Pullrequest

When an invite code is passed to the email verification, the invite code is added to the action URL and the method is changed to invite-code

Issues

@ulfgebhardt ulfgebhardt requested a review from Tirokk April 2, 2021 16:00
@ulfgebhardt ulfgebhardt added this to the 🏃 21/04 April milestone Apr 2, 2021
@ulfgebhardt
Copy link
Member

I understand that this is optional, but didn't we agree that the invite code is not part of the EMail? @Mogge

@Tirokk
Copy link
Member

Tirokk commented Apr 6, 2021

We have agreed that the invite code gets stored via Signup mutation as a relation from the EmailAddress node to the InviteCode node.
The SignupVerification mutation then uses this relation to find if the invite code was used for signup and generates the necessary relations. @Mogge
… as far I know.

@Mogge Mogge force-pushed the fix-invite-registration branch from ec1bf3e to c80b3a2 Compare April 6, 2021 11:35
@Mogge Mogge mentioned this pull request Apr 6, 2021
Closed
This was referenced Apr 6, 2021
Closed
Closed
Tirokk
Tirokk reviewed Apr 6, 2021
View reviewed changes
webapp/pages/registration.vue Outdated
)
} else {
if (
this.method === 'invite-mail' ||
(this.method === 'invite-code' && this.inviteRegistration)
) {
return this.method
if (this.method === 'invite-code' && this.inviteCode && this.nonce && this.email)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem here is that this.inviteCode, this.nonce, and this.email just do not exist, because they are only local variables in data.

We just have overlooked this. 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve done an additional commit …

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But how did it work then when we tried it? @Tirokk

@Tirokk Tirokk requested a review from ulfgebhardt April 6, 2021 13:16
ulfgebhardt
ulfgebhardt approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@ulfgebhardt ulfgebhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me, can we proceed?

@Tirokk
Copy link
Member

Tirokk commented Apr 6, 2021

We can proceed. Shall I do a new Version or shall the version 1.0.2 be removed?
How we will handle this? @ulfgebhardt

@Tirokk Tirokk merged commit 8e47940 into master Apr 6, 2021
@Tirokk Tirokk deleted the fix-invite-registration branch April 6, 2021 15:18
@Tirokk Tirokk mentioned this pull request Apr 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tirokk Tirokk Tirokk left review comments

@ulfgebhardt ulfgebhardt ulfgebhardt approved these changes

Assignees

@Mogge Mogge

Labels
feature
Projects
None yet
Milestone
🏃 21/04 April
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Email Verification Sends Out Wrong Link 🐛 [Bug] Follow Relation Is Not Set At Invite
3 participants
@Mogge @ulfgebhardt @Tirokk