Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🍰 Refactor Logos #4433

Merged
merged 12 commits into from
May 19, 2021
Merged

Conversation

Tirokk
Copy link
Member

@Tirokk Tirokk commented May 18, 2021

🍰 Pullrequest

  • Refactor logos to use same logo file for different places.
  • Show all logos with the logo component except the maintenance page, which will be done here chore: [WIP] 🍰 Refactor Maintenance Page #4434 .
    • That refactors in the direction of using other type as SVG in the future.

Issues

Todo

  • webapp/static/img/custom/Logo-Horizontal.svg: file name still not in small caps?

@Tirokk Tirokk changed the title chore: [WIP] 🍰 Refactor Logos chore: 🍰 Refactor Logos May 18, 2021
@Tirokk Tirokk requested a review from Mogge May 18, 2021 15:10
@Tirokk Tirokk self-assigned this May 18, 2021
@Tirokk Tirokk added service: backend devops docu Improvements or additions to documentation service: webapp refactor labels May 18, 2021
@Tirokk Tirokk force-pushed the 4432-fix-header-logo-rebrand-replacement branch from a1808bc to eaf35d1 Compare May 18, 2021 17:56
Copy link
Contributor

@Mogge Mogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be you want to change some variable names. I like that we have the logo component in use for every image now. Great job! Thank you!

webapp/components/Logo/Logo.vue Outdated Show resolved Hide resolved
webapp/components/Logo/Logo.vue Outdated Show resolved Hide resolved
webapp/components/Logo/Logo.vue Outdated Show resolved Hide resolved
@Tirokk Tirokk merged commit 169c334 into master May 19, 2021
@Tirokk Tirokk deleted the 4432-fix-header-logo-rebrand-replacement branch May 19, 2021 06:37
@ulfgebhardt ulfgebhardt added this to the 🏃 21/05 May milestone Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💥 [DevOps] Ocelot Logo In Header Is Not Replaced By Deployment
3 participants