Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🍰 New CSS For Internal Pages #4741

Merged
merged 3 commits into from
Oct 24, 2021
Merged

feat: 🍰 New CSS For Internal Pages #4741

merged 3 commits into from
Oct 24, 2021

Conversation

Tirokk
Copy link
Member

@Tirokk Tirokk commented Oct 20, 2021

🍰 Pullrequest

New CSS for internal pages.

Issues

Todo

  • None

@Tirokk Tirokk self-assigned this Oct 20, 2021
ulfgebhardt
ulfgebhardt reviewed Oct 20, 2021
View reviewed changes
Copy link
Member

@ulfgebhardt ulfgebhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The css is multiple times in the code. Can we not reference an external script, even tho not html-compliant, but useful: <stylesheet src="css.file"/>

@Tirokk
Copy link
Member Author

Tirokk commented Oct 21, 2021 •
edited
Loading

I and @sushidave thought about it. But where we store the css.file then?
Can we move this possible task into the future and you approve? I have it in mind. Okay?
Otherwise I would again spend many hours with it, because of so many files to change here, in the branding, and to test, that all works fine. @ulfgebhardt

@Tirokk
Copy link
Member Author

Tirokk commented Oct 23, 2021

May you approve @ulfgebhardt

@Tirokk Tirokk merged commit 32dfd07 into master Oct 24, 2021
@Tirokk Tirokk deleted the 4740-new-css-for-internal-pages branch October 24, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulfgebhardt ulfgebhardt ulfgebhardt approved these changes

@Mogge Mogge Awaiting requested review from Mogge

@sushidave sushidave Awaiting requested review from sushidave

Assignees

@Tirokk Tirokk

Labels
design refactor service: webapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 [Feature] New CSS For Internal Pages 🔧 [Refactor] Activate Internal Page For Support In Footer
2 participants
@Tirokk @ulfgebhardt