fix: 🍰 Replace Hashtag In d.tube Url #4980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for facebook is a different problem ... if a user sets his account settings ... that you can only see his data internally ... then an included source is possible for everyone behind the login ... otherwise not. |
Tirokk
changed the title
ogerly
changed the title
ogerly
changed the title
Tirokk
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
we use the oembed library, in the provider.json ... you can see what is used.
I cannot say at this point whether this is current.
As far as d.tube is concerned, nothing has changed.
but in the url you can copy from the browser is a /#!/
this causes the problem.
the only solution i found now is to remove this.
but i don't think this is a good solution. it should happen in the provider.json ... but there we have some problem in the code ...
the hashtag function is not the problem
Issues
note:
if a link from facebook shows the message 'please log in', then the user from whom this source comes has set it that way.