Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 🍰 Change image Entries In Docker Compose Files And Fix Apple M1 Problem #5073

Merged
merged 12 commits into from
Jul 18, 2022
Merged

chore: 🍰 Change image Entries In Docker Compose Files And Fix Apple M1 Problem #5073

merged 12 commits into from
Jul 18, 2022

Conversation

Tirokk
Copy link
Member

@Tirokk Tirokk commented Jul 13, 2022 •
edited
Loading

🍰 Pullrequest

Remove image entries in docker compose files and fix Apple M1 problem.

Issues

Questions

  • can the image entries really be removed from docker-compose.yml?
    • or do we have to override them by emptying them somehow by docker-compose.override.yml?
      • I just renamed them all
  • remove image entries from docker-compose.test.yml as well?
    • no, they will stay
  • may change command docker-compose to new docker compose notation?
  • fix Apple M1 Docker Compose build problem, see https://stackoverflow.com/questions/65612411/forcing-docker-to-use-linux-amd64-platform-by-default-on-macos
    • may add docker-compose.apple-m1.override.yml for overriding?
      • refine docs with Apple M1 informations and the new command?
        • $ docker-compose -f docker-compose.yml -f docker-compose.override.yml -f docker-compose.apple-m1.override.yml up
    • after that export DOCKER_DEFAULT_PLATFORM=linux/amd64 is an other possibility that work for me
      • should be set then in a global and stable manner

Todo

  • change docker compose maintenance service port from 5000 to 3001
    • because it is said that macOS has a standard use of port5000

@Tirokk Tirokk self-assigned this Jul 13, 2022
@Tirokk Tirokk added bug Something isn't working docu Improvements or additions to documentation question Further information is requested core devops service: docker discussion refactor labels Jul 13, 2022
Tirokk
Tirokk commented Jul 13, 2022
View reviewed changes
docker-compose.override.yml Outdated Show resolved Hide resolved
@Tirokk Tirokk changed the title core: 🍰 [WIP] Remove image Entries In Docker Compose Files And Fix Apple M1 Problem core: 🍰 [WIP] Change image Entries In Docker Compose Files And Fix Apple M1 Problem Jul 17, 2022
@Tirokk Tirokk changed the title core: 🍰 [WIP] Change image Entries In Docker Compose Files And Fix Apple M1 Problem core: 🍰 Change image Entries In Docker Compose Files And Fix Apple M1 Problem Jul 17, 2022
@Tirokk Tirokk changed the title core: 🍰 Change image Entries In Docker Compose Files And Fix Apple M1 Problem chore: 🍰 Change image Entries In Docker Compose Files And Fix Apple M1 Problem Jul 17, 2022
@Tirokk Tirokk requested review from Mogge and ogerly July 17, 2022 19:02
@Tirokk Tirokk marked this pull request as draft July 17, 2022 19:02
@Tirokk Tirokk marked this pull request as ready for review July 17, 2022 19:03
@Tirokk Tirokk mentioned this pull request Jul 18, 2022
Closed
24 tasks
Tirokk added 2 commits July 18, 2022 19:01
@Tirokk
Merge branch 'master' of github.com:Ocelot-Social-Community/Ocelot-So…
9143eb7 
…cial into 5072-remove-image-entries-in-docker-compose-files-fix-m1

# Conflicts:
#	DOCKER_MORE_CLOSELY.md
#	docker-compose.override.yml
#	docker-compose.test.yml
#	docker-compose.yml
@Tirokk
Switch in Docker Compose files Neo4j and maintenance
cc62d9e
@Tirokk Tirokk merged commit 50344b4 into master Jul 18, 2022
@Tirokk Tirokk deleted the 5072-remove-image-entries-in-docker-compose-files-fix-m1 branch July 18, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogerly ogerly ogerly approved these changes

@Mogge Mogge Awaiting requested review from Mogge

Assignees

@Tirokk Tirokk

Labels
bug Something isn't working core devops discussion docu Improvements or additions to documentation question Further information is requested refactor service: docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

💥 [DevOps] Remove image Entries In Docker Compose Files And Get Apple M1 Running
2 participants
@Tirokk @ogerly