Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🍰 My Groups Page #5148

Merged
merged 42 commits into from
Sep 12, 2022
Merged

feat: 🍰 My Groups Page #5148

merged 42 commits into from
Sep 12, 2022

Conversation

ogerly
Copy link
Member

@ogerly ogerly commented Aug 7, 2022 •
edited by Tirokk
Loading

🍰 Pullrequest

Preparation for

  • Settings , My groups
  • Manage groups
  • Create new groups

Issues

Todo

  • shall path be group/mygroups or just mygroups?
  • deconstruction of mutation variables in create.vue

@ogerly ogerly requested a review from Tirokk August 7, 2022 19:40
@ogerly ogerly self-assigned this Aug 7, 2022
@Tirokk Tirokk mentioned this pull request Aug 9, 2022
Closed
59 tasks
@ogerly ogerly changed the base branch from master to 5059-epic-groups September 6, 2022 10:02
@ogerly ogerly changed the base branch from 5059-epic-groups to 5059-groups/5131-implement-update-group-resolver September 6, 2022 10:17
Base automatically changed from 5059-groups/5131-implement-update-group-resolver to 5059-epic-groups September 6, 2022 17:51
@Tirokk Tirokk changed the title [WIP] 5140 my groups page fest: [WIP] 🍰 My Groups Page Sep 9, 2022
@Tirokk Tirokk changed the title fest: [WIP] 🍰 My Groups Page feat: [WIP] 🍰 My Groups Page Sep 9, 2022
Tirokk
Tirokk requested changes Sep 9, 2022
View reviewed changes
Copy link
Member

@Tirokk Tirokk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool !!! 🤗🍀

I did a kind of pre review.

I have some suggestions …

webapp/locales/de.json Outdated Show resolved Hide resolved
webapp/locales/de.json Outdated Show resolved Hide resolved
webapp/locales/en.json Outdated Show resolved Hide resolved
webapp/pages/group/create.vue Outdated Show resolved Hide resolved
webapp/pages/group/create.vue Outdated Show resolved Hide resolved
webapp/pages/group/edit/_id.vue Outdated Show resolved Hide resolved
webapp/pages/group/edit/_id/index.vue Outdated Show resolved Hide resolved
webapp/pages/group/edit/_id/index.vue Outdated Show resolved Hide resolved
webapp/pages/group/edit/_id/members.vue Outdated Show resolved Hide resolved
webapp/pages/settings.vue Outdated Show resolved Hide resolved
ogerly and others added 12 commits September 9, 2022 11:30
@ogerly @Tirokk
Update webapp/locales/de.json
a32a2d0 
Co-authored-by: Wolfgang Huß <wolle.huss@pjannto.com>
@ogerly @Tirokk
Update webapp/locales/de.json
b312ce4 
Co-authored-by: Wolfgang Huß <wolle.huss@pjannto.com>
@ogerly @Tirokk
Update webapp/locales/en.json
ca80471 
Co-authored-by: Wolfgang Huß <wolle.huss@pjannto.com>
@ogerly
change page structure for groupe settings
3d5f29c
@ogerly @Tirokk
Update webapp/pages/group/edit/_id/index.vue
07b3857 
Co-authored-by: Wolfgang Huß <wolle.huss@pjannto.com>
@ogerly
import GroupMembers component in group settings
a5d5dd7
@ogerly @Tirokk
Update webapp/components/Group/GroupForm.vue
ad02924 
Co-authored-by: Wolfgang Huß <wolle.huss@pjannto.com>
@ogerly @Tirokk
Update webapp/pages/group/edit/_id.vue
62f5768 
Co-authored-by: Wolfgang Huß <wolle.huss@pjannto.com>
@ogerly @Tirokk
Update webapp/pages/group/edit/_id.vue
7cb965e 
Co-authored-by: Wolfgang Huß <wolle.huss@pjannto.com>
@ogerly
change components add constants
a1da04e
@ogerly
fix lint
80940ae
@ogerly
resolve conflicts
26cf8f1
@ogerly ogerly requested a review from Tirokk September 9, 2022 11:19
Tirokk
Tirokk requested changes Sep 10, 2022
View reviewed changes
Copy link
Member

@Tirokk Tirokk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one little mistake @ogerly .
And the tests found locales to be fixed …

I fixed both!
Hope that's okay?

And just a comment for the future.

webapp/components/Group/GroupForm.vue Outdated Show resolved Hide resolved
webapp/pages/my-groups.vue Show resolved Hide resolved
Tirokk
Tirokk approved these changes Sep 10, 2022
View reviewed changes
Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very cool beginning @ogerly . 😍

This are really great features we started with. 🚀🚀💫💫

@Tirokk Tirokk changed the title feat: [WIP] 🍰 My Groups Page feat: 🍰 My Groups Page Sep 10, 2022
@ogerly ogerly merged commit 72eca64 into 5059-epic-groups Sep 12, 2022
@ogerly ogerly deleted the 5140-My-Groups-Page branch September 12, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tirokk Tirokk Tirokk approved these changes

Assignees

@ogerly ogerly

Labels
project: yunite service: webapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 [Feature] My Groups Page
2 participants
@ogerly @Tirokk