feat: 🍰 Implement Group Profile – Visibility #5332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-or-pending-members' of github.com:Ocelot-Social-Community/Ocelot-Social into 5059-groups/5318-group-profile-second
…/Ocelot-Social into 5059-groups/5318-group-profile-second
Tirokk
changed the title
ogerly
approved these changes
Sep 12, 2022
Mogge
requested changes
Sep 12, 2022
| groupMatchParamsCypher += index === 0 ? ' {' : '' | ||
| groupMatchParamsCypher += `${ele[0]}: "${ele[1]}"` | ||
| groupMatchParamsCypher += index < matchParamsEntries.length - 1 ? ', ' : '}' | ||
| }) |
There was a problem hiding this comment.
Can this be done in some human readable way? Am I right, that we receive an ID, a slug, both or none from the params. So I suggest, if both (ID and slug) are undefined, return empty array or throw an error. We could say, that ID goes over slug if both are present.
There was a problem hiding this comment.
I couldn't find a working solution in Cypher.
What I have found was not working. So I spent a bit more then an hour. @Mogge
I created two hopefully well named and therefore descriptive helper functions instead. Hope that satisfies you …
…cial into 5059-groups/5318-group-profile-second
…/Ocelot-Social into 5059-groups/5318-group-profile-second
… by making a resolver helper function
Mogge
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pull Request
Implement group profile – second step.
Issues
Todo
hiddengroups can only be seen by members that are notpendingWolle