feat: 🍰 Header Logo Routing Update #5579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…celot-Social into bug/issue#5550 # Conflicts: # webapp/constants/logos.js
7 tasks
Tirokk
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
Hey @adrianrojek ,
this looks and works really good! 😍
Big thank for your help 🙏🏼
I justified a little the default for undefined target and set the default setting for the template network in webapp/constants/logos.js.
Hope that was okay?!
I approve! 🚀💫
You can merge if the test are successful.
PS: Just rerun the unsucceful tests. We are working to better this …
|
Test are ready. @adrianrojek |
|
Merged, thanks @Tirokk |
|
My pleasure @adrianrojek 🍀💫 |
This was referenced Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
Updated the mobile screen header logo to route to external or internal URL according to change request from fork pull request.
Issues
Todo