Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🍰 List All Groups #5582

Merged
merged 8 commits into from
Oct 26, 2022
Merged

feat: 🍰 List All Groups #5582

merged 8 commits into from
Oct 26, 2022

Conversation

Mogge
Copy link
Contributor

@Mogge Mogge commented Oct 26, 2022

🍰 Pullrequest

List all groups

Issues

Todo

  • None

@Mogge Mogge self-assigned this Oct 26, 2022
@ulfgebhardt ulfgebhardt added this to the 🏃 22/10 Oktober milestone Oct 26, 2022
ulfgebhardt
ulfgebhardt approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@ulfgebhardt ulfgebhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise looks good, tested locally - works

image

Edgecases habe ich nicht geprüft

@Tirokk Tirokk changed the title feature: List All Groups feat: 🍰 List All Groups Oct 26, 2022
Tirokk
Tirokk approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good done @Mogge !!! 😍

I approve 🚀🚀💫💫

webapp/pages/groups.spec.js Show resolved Hide resolved
webapp/pages/groups.vue Show resolved Hide resolved
@Mogge Mogge merged commit a6517ca into master Oct 26, 2022
@Mogge Mogge deleted the list-all-groups branch October 26, 2022 16:13
@Tirokk Tirokk mentioned this pull request Oct 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tirokk Tirokk Tirokk approved these changes

@ulfgebhardt ulfgebhardt ulfgebhardt approved these changes

Assignees

@Mogge Mogge

Labels
feature service: backend service: webapp
Projects
None yet
Milestone
🏃 22/10 Oktober
Development

Successfully merging this pull request may close these issues.

🚀 [Feature] Have A List Of All Groups
3 participants
@Mogge @ulfgebhardt @Tirokk