feat: Restrict Comments on Posts in Groups #5599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tirokk
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
Hey @Mogge
Very nice that you did this !!! 😍
What I have found is:
- with this in the webapp I can comment on a post of a public group, but get an error from the backend if I submit the comment
In my eyes:
- If commenting a post in a public group shall be possible …
- we have to adjust the backend
- If commenting a post in a public group shall not be possible …
- we have to disable the commenting funktionallity on the post
- and should display the reason why this is not possible
- making a followup issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
Ensure that no posts in groups can be commented by users that are not member of the group.
Issues
Todo