-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webapp): fix donation bar blink #6107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the webapp unit test:
https://github.com/Ocelot-Social-Community/Ocelot-Social/actions/runs/4374162960/jobs/7653539481
Just set the donation default text and test to check for the new default.
Run $ yarn test
or more specific $yarn test pages/index.spec.js
in the webapp folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @maeckes-infinitylabs
nicely done and works fine. 😍
I approve 🚀💫
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
🍰 Pullrequest
Sets the default value for showing the donation bar to false, to avoid blinking.
Issues
Todo