Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webapp): fix viewportwidth=device-width by removing it #6110

Merged
merged 4 commits into from
Mar 14, 2023
Merged

fix(webapp): fix viewportwidth=device-width by removing it #6110

merged 4 commits into from
Mar 14, 2023

Conversation

Tirokk
Copy link
Member

@Tirokk Tirokk commented Mar 9, 2023 •
edited
Loading

🍰 Pullrequest

Fix viewport``width=device-width by removing it, because it does not work correctly for Safari on iOS.

Issues

Todo

  • test it on Google Android

@Tirokk Tirokk self-assigned this Mar 9, 2023
@Tirokk Tirokk added this to the 🏃 The Sprint after that... milestone Mar 9, 2023
Elweyn
Elweyn reviewed Mar 13, 2023
View reviewed changes
Copy link
Member

@Elweyn Elweyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can set the stockoverflow link in the commit message.

webapp/nuxt.config.js Outdated Show resolved Hide resolved
webapp/maintenance/source/nuxt.config.maintenance.js Outdated Show resolved Hide resolved
@Tirokk Tirokk requested a review from Elweyn March 14, 2023 06:41
Elweyn
Elweyn approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@Elweyn Elweyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Safari, Brave & mobile-devices of brave

@Tirokk Tirokk merged commit 9d16d42 into master Mar 14, 2023
@Tirokk Tirokk deleted the 5627-fix-responsive-view-on-iphone branch March 14, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elweyn Elweyn Elweyn approved these changes

@Mogge Mogge Awaiting requested review from Mogge

@ogerly ogerly Awaiting requested review from ogerly

@ulfgebhardt ulfgebhardt Awaiting requested review from ulfgebhardt

Assignees

@Tirokk Tirokk

Labels
bug Something isn't working project: yunite service: webapp
Projects
None yet
Milestone
🏃 The Sprint after that...
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Responsive View on iPhone8
2 participants
@Tirokk @Elweyn