Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webapp): add hint text to create and edit a post of a group aside of the save and abort buttons #6114

Merged
merged 13 commits into from
Mar 16, 2023

Conversation

Tirokk
Copy link
Member

@Tirokk Tirokk commented Mar 9, 2023

🍰 Pullrequest

Add hint text to create and edit a post of a group aside of the save and abort buttons.

Issues

Todo

  • may optimize the flex behaviour of the buttons to be right aligned, especially visible in EN

Elweyn
Elweyn previously requested changes Mar 13, 2023
webapp/components/ContributionForm/ContributionForm.vue Outdated Show resolved Hide resolved
webapp/components/ContributionForm/ContributionForm.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@Mogge Mogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must also check for the group type. Posts in a public group are visible to everyone

Elweyn and others added 10 commits March 16, 2023 12:08
…cial into 6068-on-create-edit-group-page-have-additional-hint
Co-authored-by: Moriz Wahl <moriz.wahl@gmx.de>
Co-authored-by: Moriz Wahl <moriz.wahl@gmx.de>
… github.com:Ocelot-Social-Community/Ocelot-Social into 6068-on-create-edit-group-page-have-additional-hint

# Conflicts:
#	webapp/components/ContributionForm/ContributionForm.vue
… github.com:Ocelot-Social-Community/Ocelot-Social into 6068-on-create-edit-group-page-have-additional-hint

# Conflicts:
#	webapp/components/ContributionForm/ContributionForm.vue
@Tirokk Tirokk requested a review from Mogge March 16, 2023 15:13
@Tirokk Tirokk merged commit 6480e9e into master Mar 16, 2023
@Tirokk Tirokk deleted the 6068-on-create-edit-group-page-have-additional-hint branch March 16, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants