feat(webapp): refactor notification page #6116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maeckes1
changed the title
maeckes1
changed the title
maeckes1
changed the title
maeckes1
changed the title
Elweyn
requested changes
Mar 13, 2023
Co-authored-by: Hannes Heine <heine.hannes@gmail.com>
|
@Elweyn I fully agree with you to use full descriptive names for variables and added your suggestions |
Co-authored-by: Hannes Heine <heine.hannes@gmail.com>
Co-authored-by: Hannes Heine <heine.hannes@gmail.com>
Co-authored-by: Hannes Heine <heine.hannes@gmail.com>
Co-authored-by: Hannes Heine <heine.hannes@gmail.com>
Co-authored-by: Hannes Heine <heine.hannes@gmail.com>
Co-authored-by: Hannes Heine <heine.hannes@gmail.com>
Elweyn
approved these changes
Mar 13, 2023
…cial into 6016-feature-refactor-notification-page
Tirokk
approved these changes
Mar 14, 2023
…cial into 6016-feature-refactor-notification-page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
Refactors the notification page to add better visibility for mobile devices.
It now uses a mixture of CSS Grid and Flex to have a responsive table for desktop views.
For mobile devices it breaks the table down in notification-row items for a better overview.
Issues
Todo