Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webapp): join leave button for pending members #6152

Merged
merged 3 commits into from
Mar 20, 2023
Merged

fix(webapp): join leave button for pending members #6152

merged 3 commits into from
Mar 20, 2023

Conversation

Mogge
Copy link
Contributor

@Mogge Mogge commented Mar 17, 2023

🍰 Pullrequest

Issues

  • None

Todo

  • None

@Mogge Mogge self-assigned this Mar 17, 2023
@Mogge Mogge added bug Something isn't working service: webapp labels Mar 17, 2023
Tirokk
Tirokk requested changes Mar 17, 2023
View reviewed changes
Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately there is no tooltip visible at the leave button named Pending member …

Not on FireFox nor on Safari.

Tirokk
Tirokk approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Mogge

great! This works fine and as expected for me. 🍀👍🏼

I approve 🚀💫

@Mogge Mogge merged commit 8e58e1a into master Mar 20, 2023
@Mogge Mogge deleted the fix-join-leave-button-for-pending-members branch March 20, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elweyn Elweyn Elweyn approved these changes

@Tirokk Tirokk Tirokk approved these changes

Assignees

@Mogge Mogge

Labels
bug Something isn't working service: webapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mogge @Tirokk @Elweyn