Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): new migration to create search indexes #6167

Merged
merged 6 commits into from
Mar 21, 2023

Conversation

ulfgebhardt
Copy link
Member

🍰 Pullrequest

new migration to create search indexes. This reduces the role of the db:migrate init functionality and sets the fulltext search indexes reliable. Furthermore the index creating is now aligned with the group index.

This migration is special in the form that the indexes are dropped in case they already exist.

Issues

  • None

Todo

  • None

@ulfgebhardt ulfgebhardt requested a review from Mogge March 20, 2023 20:02
@ulfgebhardt ulfgebhardt self-assigned this Mar 20, 2023
Copy link
Member

@Elweyn Elweyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For it seems good!
Just a question if on migration down we should also check if the index exists!?

@ulfgebhardt ulfgebhardt merged commit 29e0e10 into master Mar 21, 2023
@ulfgebhardt ulfgebhardt deleted the migration-search-indexes branch March 21, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants