Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(webapp): refine chat notification in header menu and chat button on user profile #6550

Merged
merged 8 commits into from
Jul 13, 2023
Merged

feat(webapp): refine chat notification in header menu and chat button on user profile #6550

merged 8 commits into from
Jul 13, 2023

Conversation

Tirokk
Copy link
Member

@Tirokk Tirokk commented Jul 12, 2023 •
edited
Loading

@Tirokk Tirokk self-assigned this Jul 12, 2023
@Tirokk Tirokk added this to the 🏃 The Sprint after that... milestone Jul 12, 2023
ogerly
ogerly reviewed Jul 13, 2023
View reviewed changes
Copy link
Member

@ogerly ogerly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when the user's name is displayed, it has something human about it.

webapp/pages/profile/_id/_slug.vue Outdated Show resolved Hide resolved
webapp/locales/en.json Outdated Show resolved Hide resolved
webapp/locales/de.json Outdated Show resolved Hide resolved
Tirokk and others added 5 commits July 13, 2023 08:49
@Tirokk @ogerly
Update webapp/pages/profile/_id/_slug.vue
a07a8b3 
Co-authored-by: Alexander Friedland <fridolin@tutanota.com>
@Tirokk @ogerly
Update webapp/locales/en.json
afcb2a1 
Co-authored-by: Alexander Friedland <fridolin@tutanota.com>
@Tirokk @ogerly
Update webapp/locales/de.json
f0826e6 
Co-authored-by: Alexander Friedland <fridolin@tutanota.com>
@Tirokk
Put user name in the tooltip of the chat button on the user profile
40774b0
@Tirokk
Change store commits into 'mapMutations' on user profile
34bb207
@Tirokk Tirokk requested a review from ogerly July 13, 2023 07:31
Elweyn
Elweyn approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@Elweyn Elweyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great for me! Thank you!
We need a ticket for two points:

  • Show count of open messages
  • If small chat is open and we go on another user and open it again it shows not the new room

@Tirokk Tirokk merged commit f2f003d into master Jul 13, 2023
@Tirokk Tirokk deleted the 6542-chat-in-header branch July 13, 2023 08:48
ogerly
ogerly reviewed Jul 13, 2023
View reviewed changes
Copy link
Member

@ogerly ogerly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogerly ogerly ogerly left review comments

@Elweyn Elweyn Elweyn approved these changes

@ulfgebhardt ulfgebhardt ulfgebhardt approved these changes

@maeckes1 maeckes1 Awaiting requested review from maeckes1

@entermex entermex Awaiting requested review from entermex

Assignees

@Tirokk Tirokk

Labels
chat design feature project: yunite service: docker
Projects
Kanban Board Ocelot-Social Software
Status: Done
Milestone
🏃 The Sprint after that...
4 participants
@Tirokk @ulfgebhardt @ogerly @Elweyn