-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webapp): event date format #6784
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a migration of the DB? @Mogge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That does work on Safari and Firefox. 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- care for the summer and winter time @ulfgebhardt
- may we can use the creation date to distinguish between it?
- !!! we decided to set winter time in the migration !!!
- give a backend error if the frontend sends not UTC datetime? @Mogge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should define a time before this transformation happens and one after this will not happen.
if(post.createdAt is before XXX)
If we should do the extra effort to calculate the summer and winter offset is not important to me.
I do not fully understand if the problem is solved with the Conversion to Date - i assume it takes the given timezone and converts it to UTC, but thats an assumption.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works excelent. @Mogge
Therefore I approve 🚀🚀💫💫
PS: I tested the error message in the browser as well. Cool! 😍
PPS: And you already corrected the hour offset. 👍🏼
!!! Before we merge we have to prepare the stage.yunite.me to test the migration on the server !!! |
…unity/Ocelot-Social into fix-event-date-format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A very good idea to take the migration out of the coverage. 👍🏼
!!! Before we merge we have to prepare the stage.yunite.me to test the migration on the server !!! |
Test migration on
MATCH (event:Event) WHERE NOT event.eventStart CONTAINS 'T' RETURN event.id, event.eventStart, event.eventEnd; Or: MATCH (event:Event) RETURN event.id, event.eventStart, event.eventEnd; |
🍰 Pullrequest
Issues
Todo