Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(webapp): replace deprecated jest methods in webapp unit tests #6808

Merged
merged 3 commits into from
Oct 31, 2023
Merged

refactor(webapp): replace deprecated jest methods in webapp unit tests #6808

merged 3 commits into from
Oct 31, 2023

Conversation

mahula
Copy link
Contributor

@mahula mahula commented Oct 31, 2023 •
edited
Loading

🍰 Pullrequest

In the webapp Jest v29.5 is used.
Several method from our unit tests are deprecated in this Jest versin

Todo

Replace deprecatedmethods with current equivalent

  • toBeCalled --> toHaveBeenCalled
  • toBeCalledWith --> toHaveBeenCalledWith
  • toBeCalledTimes --> toHaveBeenCalledTimes

Issues

@mahula mahula self-assigned this Oct 31, 2023
@mahula mahula requested review from Tirokk and Elweyn October 31, 2023 10:26
Tirokk
Tirokk approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @mahula 😍

Works fine locally!

@Tirokk Tirokk merged commit cee9da0 into master Oct 31, 2023
24 checks passed
@Tirokk Tirokk deleted the replace-deprecated-jest-method branch October 31, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tirokk Tirokk Tirokk approved these changes

@Elweyn Elweyn Awaiting requested review from Elweyn

Assignees

@mahula mahula

Labels
refactor service: webapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahula @Tirokk