Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(other): ignore changelog file in markdown link checker #6933

Merged
merged 8 commits into from
Jan 9, 2024
Merged

refactor(other): ignore changelog file in markdown link checker #6933

merged 8 commits into from
Jan 9, 2024

Conversation

mahula
Copy link
Contributor

@mahula mahula commented Jan 9, 2024 •
edited
Loading

🍰 Pullrequest

Remove CHANGELOG.mdfrom Markdown Link Check

@mahula mahula marked this pull request as draft January 9, 2024 13:04
@mahula mahula self-assigned this Jan 9, 2024
@mahula mahula changed the title refactor(other): Ignore changelog file in markdown link checker refactor(other): ignore changelog file in markdown link checker Jan 9, 2024
@mahula mahula requested a review from Tirokk January 9, 2024 14:23
@mahula mahula marked this pull request as ready for review January 9, 2024 14:23
Tirokk
Tirokk approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's cool for now in my eyes @mahula
And there's no link to CHANGELOG.md in the readmes at all as far I can see. So no danger
👍🏼

@mahula mahula merged commit 6afc8b9 into master Jan 9, 2024
27 checks passed
@mahula mahula deleted the ignore-changelog-file-in-markdown-link-checker branch January 9, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tirokk Tirokk Tirokk approved these changes

Assignees

@mahula mahula

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahula @Tirokk