Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to ignore version of rootPackage #142

Closed
qurben opened this issue May 24, 2020 · 4 comments · Fixed by #155
Closed

Option to ignore version of rootPackage #142

qurben opened this issue May 24, 2020 · 4 comments · Fixed by #155
Assignees
Milestone

Comments

@qurben
Copy link

qurben commented May 24, 2020

We depend on a package which depends on this package. We noticed that Versions.php updates for every version we put out, even when the changes in our repository are not part of the deployed code.

We would like to see that if we don't change our composer.lock file or add/remove/rename php files, the contents of vendor do not change.

Is there a way to disable generating versions for the rootPackage or make sure that the rootPackage is always the same version?

@Ocramius
Copy link
Owner

Ocramius commented May 24, 2020 via email

@qurben
Copy link
Author

qurben commented May 24, 2020

It produces noise in our deployment setup, every commit is also a change in Versions.php, but we rather not remove Versions.php altogether as this might break something we depend on.

If there is a nice way to configure this it would be very nice, else we would just script something to remove the line after it is generated.

@Ocramius
Copy link
Owner

Ocramius commented May 24, 2020 via email

@Ocramius
Copy link
Owner

@Ocramius Ocramius added this to the 2.0.0 milestone Jul 11, 2020
@Ocramius Ocramius self-assigned this Jul 11, 2020
Ocramius added a commit that referenced this issue Aug 21, 2020
…NAME` constant

This simplifies the tool to no longer be a plugin: `PackageVersions\Versions` is now a much simpler
class that is no longer generated/written to disk at installation, and `ocramius/package-versions`
is no longer a `"type": "composer-plugin"`, but rather a more usual `"type": "library"` package.

This:

 * Fixes #138 - this library no longer changes `vendor` post-installation
 * Fixes #142 - the `rootPackage` version is now detected via composer, and no longer leads to
   changes in `vendor/ocramius/package-versions/src/PackageVersions/Versions.php` at each change
   of source root in a project
 * Fixes #152 - when `"lock": false` is used in composer, since we no longer access lock file
   information from sources of this package
 * Fixes #107 - writing to `vendor` is no longer happening from this library, so no file access
   rights should be needed.
Ocramius added a commit that referenced this issue Aug 21, 2020
…NAME` constant

This simplifies the tool to no longer be a plugin: `PackageVersions\Versions` is now a much simpler
class that is no longer generated/written to disk at installation, and `ocramius/package-versions`
is no longer a `"type": "composer-plugin"`, but rather a more usual `"type": "library"` package.

This:

 * Fixes #138 - this library no longer changes `vendor` post-installation
 * Fixes #142 - the `rootPackage` version is now detected via composer, and no longer leads to
   changes in `vendor/ocramius/package-versions/src/PackageVersions/Versions.php` at each change
   of source root in a project
 * Fixes #152 - when `"lock": false` is used in composer, since we no longer access lock file
   information from sources of this package
 * Fixes #107 - writing to `vendor` is no longer happening from this library, so no file access
   rights should be needed.
Ocramius added a commit that referenced this issue Aug 21, 2020
…the-need-for-generating-version-class

BC break: removed deprecated `PackageVersions\Versions::ROOT_PACKAGE_NAME` constant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants