Remove redundant error handler in generate #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to webimpress/safe-writer#49 The problem is with testing in ocramius/proxy-manager, not in safe-writer itself.
|
Aha, I guess the Still, won't that trip tools like sentry, which declare custom error handlers to catch these cases? 🤔 |
Ocramius
approved these changes
Apr 19, 2021
| @@ -44,16 +37,12 @@ public function generate(ClassGenerator $classGenerator): string | |||
| $className = $classGenerator->getNamespaceName() . '\\' . $classGenerator->getName(); | |||
| $fileName = $this->fileLocator->getProxyFileName($className); | |||
|
|
|||
| set_error_handler($this->emptyErrorHandler); | |||
There was a problem hiding this comment.
Discussed in chat: change is valid, I just want to merge the removal of the error handlers separately from the test adjustment first, but overall 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to webimpress/safe-writer#49
The problem is with testing in ocramius/proxy-manager, not in safe-writer itself.
Update: still it can be improved in safe-writer to set custom error-handler instead of suppressing warnings with
@.